Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fluentd-gcp-scaler version #61225

Merged
merged 1 commit into from Mar 15, 2018

Conversation

@x13n
Copy link
Member

x13n commented Mar 15, 2018

What this PR does / why we need it:
This version verifies on its own whether resources should be updated or not, instead of relying on kubectl set resources.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #61190

Special notes for your reviewer:

Release note:

NONE

cc @shyamjvs

Bump fluentd-gcp-scaler version
Fixes #61190.

This version verifies on its own whether resources should be updated or not, instead of relying on `kubectl set resources`.
@x13n

This comment has been minimized.

Copy link
Member Author

x13n commented Mar 15, 2018

/assign @crassirostris

@crassirostris

This comment has been minimized.

Copy link
Member

crassirostris commented Mar 15, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 15, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 15, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crassirostris, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crassirostris

This comment has been minimized.

Copy link
Member

crassirostris commented Mar 15, 2018

Moving this to 1.10, since it blocks a critical bug

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Mar 15, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@crassirostris @x13n

Pull Request Labels
  • sig/instrumentation: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help
@crassirostris

This comment has been minimized.

Copy link
Member

crassirostris commented Mar 15, 2018

e2e test is failing because of kubernetes/test-infra#7295

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Mar 15, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@dims

This comment has been minimized.

Copy link
Member

dims commented Mar 15, 2018

/test pull-kubernetes-e2e-gce

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Mar 15, 2018

Automatic merge from submit-queue (batch tested with PRs 60888, 61225). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 448f9a3 into kubernetes:master Mar 15, 2018

14 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation x13n authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@x13n x13n deleted the x13n:fluentd-gcp-scaler branch Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.