Skip to content

/kubernetes

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove examples directory #61246

Merged
merged 1 commit into from Apr 24, 2018

Conversation

Reviewers

@zouyee zouyee

@jeffmendoza jeffmendoza

@liggitt liggitt

@zmerlynn zmerlynn

@a-robinson a-robinson

@pwittrock pwittrock

Assignees

@ahmetb ahmetb

@thockin thockin

@deads2k deads2k

Labels
approved cncf-cla: yes lgtm release-note-none size/XXL
Projects
None yet
Milestone
No milestone
10 participants
@serathius @k8s-ci-robot @ahmetb @zouyee @ixdy @BenTheElder @deads2k @spiffxp @thockin @k8s-github-robot
@serathius
Copy link
Contributor

commented Mar 15, 2018 •
edited

Removes examples directory, which was migrated kubernetes/examples#210
Moves manifests used in tests to test/e2e/testing-manifests
I will submit PR to https://github.com/kubernetes/k8s.io to fix links to https://releases.k8s.io/*/examples
Fixes #60887

Special notes for your reviewer:

NONE

cc @ahmetb @ixdy

@k8s-ci-robot k8s-ci-robot added release-note-none do-not-merge/blocked-paths labels Mar 15, 2018

@k8s-ci-robot

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Mar 15, 2018

@serathius: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[examples/ has moved to https://github.com/kubernetes/examples/]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XXL needs-ok-to-test labels Mar 15, 2018

@k8s-ci-robot k8s-ci-robot requested review from a-robinson, jeffmendoza, liggitt, pwittrock, zmerlynn and zouyee Mar 15, 2018

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes label Mar 15, 2018

@ahmetb

This comment has been minimized.

Sign in to view
Copy link
Member

commented Mar 16, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test label Mar 16, 2018

@serathius serathius force-pushed the serathius:remove-examples branch 9 times, most recently from 2710c66 to ed23c2d Mar 19, 2018

@zouyee

This comment has been minimized.

Sign in to view
Copy link
Member

commented Mar 22, 2018

/test pull-kubernetes-integration
@zouyee

zouyee reviewed Mar 22, 2018
View changes

Copy link
Member

left a comment

I think some changes need to be splited

@serathius serathius force-pushed the serathius:remove-examples branch from ed23c2d to 4918dff Mar 22, 2018

@ahmetb

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 5, 2018

@serathius any blockers here?

@serathius serathius force-pushed the serathius:remove-examples branch from 4918dff to 5f67a89 Apr 9, 2018

@serathius

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Apr 9, 2018

No, I waited for redirect in k8s. Forgot to rerun tests.

@serathius serathius force-pushed the serathius:remove-examples branch from 5f67a89 to a9f5cf7 Apr 13, 2018

@k8s-github-robot k8s-github-robot merged commit e5274b6 into kubernetes:master Apr 24, 2018
14 of 15 checks passed

14 of 15 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation serathius authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@ahmetb

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 24, 2018

Thank you so much @serathius.

If we get complaints about examples/ directory disappearing altogether, we can add a README.md pointing to the new repo but we already had that for > 6 months.

@cblecker cblecker referenced this pull request Apr 25, 2018

Merged

Clean up and remove unused deps #63129

k8s-github-robot pushed a commit that referenced this pull request Apr 25, 2018

Kubernetes Submit Queue
Merge pull request #63129 from cblecker/clean-unneeded-deps-apr24 
Automatic merge from submit-queue (batch tested with PRs 63129, 63066, 60009, 63136, 63086). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Clean up and remove unused deps

**What this PR does / why we need it**:
The `examples/` directory was removed in #61246, but it's deps weren't cleaned up.

**Release note**:
```release-note
NONE
```
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c944882

@warmchang warmchang referenced this pull request Apr 27, 2018

Closed

kubectl-container no longer exists in the kubernetes/examples repo #60498

lathama added a commit to lathama/kubernetes that referenced this pull request Aug 14, 2018

@lathama
from kubernetes#61246 note removed examples and regression for master
00c7502

@lathama lathama referenced this pull request Aug 14, 2018

Merged

from #61246 note removed examples and regression for master #67401

pohly added a commit to pohly/kubernetes that referenced this pull request Sep 3, 2018

@pohly
e2e/examples: remove obsolete tests 
These tests depend on files that were removed in
kubernetes#61246 and thus can no
longer be run in Kubernetes. Moving the tests to kubernetes/examples
is tracked in kubernetes/examples#214.

The file removal did not break the automated E2E testing probably
because the tests are under the Feature:Example tag and thus not
enabled during normal CI runs.

Removing also the obsolete tests makes it simpler to rework the
"repo-root" setting because less code uses it.
a1edf22

@pohly pohly referenced this pull request Sep 3, 2018

Closed

e2e/examples: remove obsolete tests #68187

pohly added a commit to pohly/kubernetes that referenced this pull request Sep 3, 2018

@pohly
e2e/examples: remove obsolete tests 
These tests depend on files that were removed in
kubernetes#61246 and thus can no
longer be run in Kubernetes. Moving the tests to kubernetes/examples
is tracked in kubernetes/examples#214.

The file removal did not break the automated E2E testing probably
because the tests are under the Feature:Example tag and thus not
enabled during normal CI runs.

Removing also the obsolete tests makes it simpler to rework the
"repo-root" setting because less code uses it.
f6a7ef8

pohly added a commit to pohly/kubernetes that referenced this pull request Sep 3, 2018

@pohly
e2e/examples: remove obsolete tests 
These tests depend on files that were removed in
kubernetes#61246 and thus can no
longer be run in Kubernetes. Moving the tests to kubernetes/examples
is tracked in kubernetes/examples#214.

The file removal did not break the automated E2E testing probably
because the tests are under the Feature:Example tag and thus not
enabled during normal CI runs.

Removing also the obsolete tests makes it simpler to rework the
"repo-root" setting because less code uses it.
dcbb66e

pohly added a commit to pohly/kubernetes that referenced this pull request Sep 4, 2018

@pohly
e2e/examples: remove obsolete tests 
These tests depend on files that were removed in
kubernetes#61246 and thus can no
longer be run in Kubernetes. Moving the tests to kubernetes/examples
is tracked in kubernetes/examples#214.

The file removal did not break the automated E2E testing probably
because the tests are under the Feature:Example tag and thus not
enabled during normal CI runs.

Removing also the obsolete tests makes it simpler to rework the
"repo-root" setting because less code uses it.
d949a2e

pohly added a commit to pohly/kubernetes that referenced this pull request Sep 7, 2018

@pohly
e2e/examples: remove obsolete tests 
These tests depend on files that were removed in
kubernetes#61246 and thus can no
longer be run in Kubernetes. Moving the tests to kubernetes/examples
is tracked in kubernetes/examples#214.

The file removal did not break the automated E2E testing probably
because the tests are under the Feature:Example tag and thus not
enabled during normal CI runs.

Removing also the obsolete tests makes it simpler to rework the
"repo-root" setting because less code uses it.
2f4ad13

pohly added a commit to pohly/kubernetes that referenced this pull request Sep 10, 2018

@pohly
e2e/examples: remove obsolete tests 
These tests depend on files that were removed in
kubernetes#61246 and thus can no
longer be run in Kubernetes. Moving the tests to kubernetes/examples
is tracked in kubernetes/examples#214.

The file removal did not break the automated E2E testing probably
because the tests are under the Feature:Example tag and thus not
enabled during normal CI runs.

Removing also the obsolete tests makes it simpler to rework the
"repo-root" setting because less code uses it.
eb0f830

pohly added a commit to pohly/kubernetes that referenced this pull request Sep 11, 2018

@pohly
e2e/examples: remove obsolete tests 
These tests depend on files that were removed in
kubernetes#61246 and thus can no
longer be run in Kubernetes. Moving the tests to kubernetes/examples
is tracked in kubernetes/examples#214.

The file removal did not break the automated E2E testing probably
because the tests are under the Feature:Example tag and thus not
enabled during normal CI runs.

Removing also the obsolete tests makes it simpler to rework the
"repo-root" setting because less code uses it.
1c6ad65

pohly added a commit to pohly/kubernetes that referenced this pull request Sep 14, 2018

@pohly
e2e/examples: remove obsolete tests 
These tests depend on files that were removed in
kubernetes#61246 and thus can no
longer be run in Kubernetes. Moving the tests to kubernetes/examples
is tracked in kubernetes/examples#214.

The file removal did not break the automated E2E testing probably
because the tests are under the Feature:Example tag and thus not
enabled during normal CI runs.

Removing also the obsolete tests makes it simpler to rework the
"repo-root" setting because less code uses it.
2503374

@dougm dougm referenced this pull request Sep 14, 2018

Closed

Examples link missing for 1.12.0 in anago email #629

pohly added a commit to pohly/kubernetes that referenced this pull request Sep 25, 2018

@pohly
e2e/examples: remove obsolete tests 
These tests depend on files that were removed in
kubernetes#61246 and thus can no
longer be run in Kubernetes. Moving the tests to kubernetes/examples
is tracked in kubernetes/examples#214.

The file removal did not break the automated E2E testing probably
because the tests are under the Feature:Example tag and thus not
enabled during normal CI runs.

Removing also the obsolete tests makes it simpler to rework the
"repo-root" setting because less code uses it.
8a66282

pohly added a commit to pohly/kubernetes that referenced this pull request Sep 27, 2018

@pohly
e2e: abstract access to additional files 
The new test/e2e/framework/testfiles package makes it possible to
write tests that do not depend on a specific way of providing
additional test files at runtime. Such tests and the framework are
then more easily reused in other test suites.

In the test/e2e suite file access is enabled based on the existing
"repo-root" command line parameter and the built-in bindata. Tests
using the new API will first check for files under "repo-root" and
then fall back to the builtin data. This way, users of a test binary
can modify those files without having to rebuild the binary.

"repo-root" is still needed because at least some tests check for
additional files (secret.yaml, via ingress_utils.go) that are not part
of the upstream source code and thus may or may not be built into a
test binary.

Tests using bindata or repo-root directly get modified to use the new
API, or removed when they are obsolete: test/e2e/examples.go depended
on files that were removed in
kubernetes#61246 and thus can no
longer be run in Kubernetes. Moving the tests to kubernetes/examples
is tracked in kubernetes/examples#214.

The file removal did not break the automated E2E testing probably
because the tests are under the Feature:Example tag and thus not
enabled during normal CI runs.

Removing also the obsolete tests makes it simpler to rework the
"repo-root" setting because less code uses it.

Related-to: kubernetes#66649 and kubernetes#23987
6c8e1f9

pohly added a commit to pohly/kubernetes that referenced this pull request Sep 27, 2018

@pohly
e2e: abstract access to additional files 
The new test/e2e/framework/testfiles package makes it possible to
write tests that do not depend on a specific way of providing
additional test files at runtime. Such tests and the framework are
then more easily reused in other test suites.

In the test/e2e suite file access is enabled based on the existing
"repo-root" command line parameter and the built-in bindata. Tests
using the new API will first check for files under "repo-root" and
then fall back to the builtin data. This way, users of a test binary
can modify those files without having to rebuild the binary.

"repo-root" is still needed because at least some tests check for
additional files (secret.yaml, via ingress_utils.go) that are not part
of the upstream source code and thus may or may not be built into a
test binary.

Tests using bindata or repo-root directly get modified to use the new
API, or removed when they are obsolete: test/e2e/examples.go depended
on files that were removed in
kubernetes#61246 and thus can no
longer be run in Kubernetes. Moving the tests to kubernetes/examples
is tracked in kubernetes/examples#214.

The file removal did not break the automated E2E testing probably
because the tests are under the Feature:Example tag and thus not
enabled during normal CI runs.

Removing also the obsolete tests makes it simpler to rework the
"repo-root" setting because less code uses it.

Related-to: kubernetes#66649 and kubernetes#23987
dfaa20e

pohly added a commit to pohly/kubernetes that referenced this pull request Sep 27, 2018

@pohly
e2e: abstract access to additional files 
The new test/e2e/framework/testfiles package makes it possible to
write tests that do not depend on a specific way of providing
additional test files at runtime. Such tests and the framework are
then more easily reused in other test suites.

In the test/e2e suite file access is enabled based on the existing
"repo-root" command line parameter and the built-in bindata. Tests
using the new API will first check for files under "repo-root" and
then fall back to the builtin data. This way, users of a test binary
can modify those files without having to rebuild the binary.

"repo-root" is still needed because at least some tests check for
additional files (secret.yaml, via ingress_utils.go) that are not part
of the upstream source code and thus may or may not be built into a
test binary.

Tests using bindata or repo-root directly get modified to use the new
API, or removed when they are obsolete: test/e2e/examples.go depended
on files that were removed in
kubernetes#61246 and thus can no
longer be run in Kubernetes. Moving the tests to kubernetes/examples
is tracked in kubernetes/examples#214.

The file removal did not break the automated E2E testing probably
because the tests are under the Feature:Example tag and thus not
enabled during normal CI runs.

Removing also the obsolete tests makes it simpler to rework the
"repo-root" setting because less code uses it.

Related-to: kubernetes#66649 and kubernetes#23987
8ed3a0e

k8s-ci-robot added a commit that referenced this pull request Sep 27, 2018

@k8s-ci-robot
Merge pull request #67401 from lathama/lathama-examples 
from #61246 note removed examples and regression for master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
2220780

pohly added a commit to pohly/kubernetes that referenced this pull request Sep 28, 2018

@pohly
e2e: abstract access to additional files 
The new test/e2e/framework/testfiles package makes it possible to
write tests that do not depend on a specific way of providing
additional test files at runtime. Such tests and the framework are
then more easily reused in other test suites.

In the test/e2e suite file access is enabled based on the existing
"repo-root" command line parameter and the built-in bindata. Tests
using the new API will first check for files under "repo-root" and
then fall back to the builtin data. This way, users of a test binary
can modify those files without having to rebuild the binary.

"repo-root" is still needed because at least some tests check for
additional files (secret.yaml, via ingress_utils.go) that are not part
of the upstream source code and thus may or may not be built into a
test binary.

Tests using bindata or repo-root directly get modified to use the new
API, or removed when they are obsolete: test/e2e/examples.go depended
on files that were removed in
kubernetes#61246 and thus can no
longer be run in Kubernetes. Moving the tests to kubernetes/examples
is tracked in kubernetes/examples#214.

The file removal did not break the automated E2E testing probably
because the tests are under the Feature:Example tag and thus not
enabled during normal CI runs.

Removing also the obsolete tests makes it simpler to rework the
"repo-root" setting because less code uses it.

Related-to: kubernetes#66649 and kubernetes#23987
d848b87

pohly added a commit to pohly/kubernetes that referenced this pull request Oct 2, 2018

@pohly
e2e: abstract access to additional files 
The new test/e2e/framework/testfiles package makes it possible to
write tests that do not depend on a specific way of providing
additional test files at runtime. Such tests and the framework are
then more easily reused in other test suites.

In the test/e2e suite file access is enabled based on the existing
"repo-root" command line parameter and the built-in bindata. Tests
using the new API will first check for files under "repo-root" and
then fall back to the builtin data. This way, users of a test binary
can modify those files without having to rebuild the binary.

"repo-root" is still needed because at least some tests check for
additional files (secret.yaml, via ingress_utils.go) that are not part
of the upstream source code and thus may or may not be built into a
test binary.

Tests using bindata or repo-root directly get modified to use the new
API, or removed when they are obsolete: test/e2e/examples.go depended
on files that were removed in
kubernetes#61246 and thus can no
longer be run in Kubernetes. Moving the tests to kubernetes/examples
is tracked in kubernetes/examples#214.

The file removal did not break the automated E2E testing probably
because the tests are under the Feature:Example tag and thus not
enabled during normal CI runs.

Removing also the obsolete tests makes it simpler to rework the
"repo-root" setting because less code uses it.

Related-to: kubernetes#66649 and kubernetes#23987
212af1a

vithati added a commit to vithati/kubernetes that referenced this pull request Oct 25, 2018

@pohly @vithati
e2e: abstract access to additional files 
The new test/e2e/framework/testfiles package makes it possible to
write tests that do not depend on a specific way of providing
additional test files at runtime. Such tests and the framework are
then more easily reused in other test suites.

In the test/e2e suite file access is enabled based on the existing
"repo-root" command line parameter and the built-in bindata. Tests
using the new API will first check for files under "repo-root" and
then fall back to the builtin data. This way, users of a test binary
can modify those files without having to rebuild the binary.

"repo-root" is still needed because at least some tests check for
additional files (secret.yaml, via ingress_utils.go) that are not part
of the upstream source code and thus may or may not be built into a
test binary.

Tests using bindata or repo-root directly get modified to use the new
API, or removed when they are obsolete: test/e2e/examples.go depended
on files that were removed in
kubernetes#61246 and thus can no
longer be run in Kubernetes. Moving the tests to kubernetes/examples
is tracked in kubernetes/examples#214.

The file removal did not break the automated E2E testing probably
because the tests are under the Feature:Example tag and thus not
enabled during normal CI runs.

Removing also the obsolete tests makes it simpler to rework the
"repo-root" setting because less code uses it.

Related-to: kubernetes#66649 and kubernetes#23987
3c8cd97

goodluckbot added a commit to goodluckbot/kubernetes that referenced this pull request Nov 11, 2018

@lathama @goodluckbot
from kubernetes#61246 note removed examples and regression for master
09f30b2

goodluckbot added a commit to goodluckbot/kubernetes that referenced this pull request Nov 11, 2018

@pohly @goodluckbot
e2e: abstract access to additional files 
The new test/e2e/framework/testfiles package makes it possible to
write tests that do not depend on a specific way of providing
additional test files at runtime. Such tests and the framework are
then more easily reused in other test suites.

In the test/e2e suite file access is enabled based on the existing
"repo-root" command line parameter and the built-in bindata. Tests
using the new API will first check for files under "repo-root" and
then fall back to the builtin data. This way, users of a test binary
can modify those files without having to rebuild the binary.

"repo-root" is still needed because at least some tests check for
additional files (secret.yaml, via ingress_utils.go) that are not part
of the upstream source code and thus may or may not be built into a
test binary.

Tests using bindata or repo-root directly get modified to use the new
API, or removed when they are obsolete: test/e2e/examples.go depended
on files that were removed in
kubernetes#61246 and thus can no
longer be run in Kubernetes. Moving the tests to kubernetes/examples
is tracked in kubernetes/examples#214.

The file removal did not break the automated E2E testing probably
because the tests are under the Feature:Example tag and thus not
enabled during normal CI runs.

Removing also the obsolete tests makes it simpler to rework the
"repo-root" setting because less code uses it.

Related-to: kubernetes#66649 and kubernetes#23987
d86913b

goodluckbot added a commit to goodluckbot/kubernetes that referenced this pull request Nov 11, 2018

@lathama @goodluckbot
from kubernetes#61246 note removed examples and regression for master
81a7a84

ParvJain added a commit to ParvJain/website that referenced this pull request Dec 6, 2018

@ParvJain
Updated the links for example repository 
example folder was migrated to it's own repository 
related: kubernetes/kubernetes#61246
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
5fa7c06

@ParvJain ParvJain referenced this pull request Dec 6, 2018

Closed

Updated the links for example repository #11564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.