New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cpu cfs quota flag with pod cgroups #61294

Merged
merged 1 commit into from Mar 19, 2018

Conversation

@derekwaynecarr
Member

derekwaynecarr commented Mar 16, 2018

What this PR does / why we need it:
It fixes the cpu-cfs-quota flag in the kubelet when pod cgroups are enabled.

Which issue(s) this PR fixes
Fixes #61293

Special notes for your reviewer:
This is a regression reported by some of our users that disable cpu quota enforcement.

Release note:

Fix regression where kubelet --cpu-cfs-quota flag did not work when --cgroups-per-qos was enabled
@derekwaynecarr

This comment has been minimized.

Member

derekwaynecarr commented Mar 16, 2018

fyi @sjenning @aveshagarwal - still need to fix unit tests and ensure it passes cross-compile.

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Mar 16, 2018

@aveshagarwal

This comment has been minimized.

Member

aveshagarwal commented Mar 16, 2018

I tested this PR and it is working as expected.

@sjenning

This comment has been minimized.

Contributor

sjenning commented Mar 16, 2018

/test cross

@sjenning

This comment has been minimized.

Contributor

sjenning commented Mar 16, 2018

/test pull-kubernetes-cross

@derekwaynecarr derekwaynecarr changed the title from WIP: Fix cpu cfs quota flag with pod cgroups to Fix cpu cfs quota flag with pod cgroups Mar 17, 2018

@derekwaynecarr

This comment has been minimized.

Member

derekwaynecarr commented Mar 17, 2018

/kind bug

@derekwaynecarr

This comment has been minimized.

Member

derekwaynecarr commented Mar 17, 2018

/sig node

@derekwaynecarr

This comment has been minimized.

Member

derekwaynecarr commented Mar 17, 2018

this is a regression and should also probably be picked into 1.9

@derekwaynecarr

This comment has been minimized.

Member

derekwaynecarr commented Mar 17, 2018

/priority critical-urgent

@dims

This comment has been minimized.

Member

dims commented Mar 17, 2018

@liggitt wanna peek at this?

LGTM 👍

@jdumars

This comment has been minimized.

Member

jdumars commented Mar 18, 2018

@yujuhong @pmorie PTAL ~ needs an LGTM and approved-for-milestone label ASAP, otherwise we're going to have to cherry pick this into 1.10.

@dims

This comment has been minimized.

Member

dims commented Mar 19, 2018

@dchen1107 @Random-Liu @vishh - one of you around to LGTM this?

@derekwaynecarr

This comment has been minimized.

Member

derekwaynecarr commented Mar 19, 2018

/status approved-for-milestone

@sjenning

This comment has been minimized.

Contributor

sjenning commented Mar 19, 2018

/lgtm

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 19, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@derekwaynecarr @sjenning

Pull Request Labels
  • sig/node: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Mar 19, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 19, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 19, 2018

Automatic merge from submit-queue (batch tested with PRs 61351, 61294). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 67be0a9 into kubernetes:master Mar 19, 2018

4 of 14 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-bazel-build
Details
pull-kubernetes-bazel-build Job triggered.
Details
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job triggered.
Details
pull-kubernetes-e2e-kops-aws Job triggered.
Details
pull-kubernetes-integration Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce Job triggered.
Details
pull-kubernetes-node-e2e Job triggered.
Details
pull-kubernetes-typecheck Job triggered.
Details
pull-kubernetes-verify Job triggered.
Details
cla/linuxfoundation derekwaynecarr authorized
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Mar 19, 2018

@derekwaynecarr: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce f68f3ff link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot added a commit to openshift/origin that referenced this pull request Mar 24, 2018

Merge pull request #19028 from derekwaynecarr/bz-1554471
Automatic merge from submit-queue.

UPSTREAM: 61294: Fix cpu cfs quota flag with pod cgroups

https://bugzilla.redhat.com/show_bug.cgi?id=1554471

Upstream: kubernetes/kubernetes#61294

openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Mar 24, 2018

Merge pull request kubernetes#19028 from derekwaynecarr/bz-1554471
Automatic merge from submit-queue.

UPSTREAM: 61294: Fix cpu cfs quota flag with pod cgroups

https://bugzilla.redhat.com/show_bug.cgi?id=1554471

Upstream: kubernetes#61294

Origin-commit: 248eabbd43cc3b677ce96cc4fdc4c00eda0c44b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment