New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch glbc manifest to use version 1.0.0. Also add rate limiting flags #61302

Merged
merged 1 commit into from Mar 19, 2018

Conversation

@rramkumar1
Member

rramkumar1 commented Mar 16, 2018

Will also add a release note to the 1.10 google doc as well.

Fixes: #61305

/assign @bowei
/cc @nicksardo

Release Note:

Bump ingress-gce image in glbc.manifest to 1.0.0
@nicksardo

This comment has been minimized.

Member

nicksardo commented Mar 16, 2018

/lgtm
Leaving approval to @bowei

@bowei

This comment has been minimized.

Member

bowei commented Mar 16, 2018

/approve

need to probably have release notes

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Mar 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, nicksardo, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jdumars

This comment has been minimized.

Member

jdumars commented Mar 19, 2018

Approved per release meeting 3/19/2018
cc: @thockin

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 19, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@rramkumar1

This comment has been minimized.

Member

rramkumar1 commented Mar 19, 2018

/kind bug
/priority critical-urgent

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 19, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@bowei @nicksardo @rramkumar1

Pull Request Labels
  • sig/gcp: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help
@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 19, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit dcbfdfc into kubernetes:master Mar 19, 2018

13 of 14 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation rramkumar1 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment