Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable DaemonSet scheduling feature for 1.10 #61411

Merged
merged 1 commit into from Mar 20, 2018

Conversation

@liggitt
Copy link
Member

liggitt commented Mar 20, 2018

The DaemonSet scheduling feature has blocked the alpha CI job being green and is preventing getting good CI signal for v1.10

It still contains pod scheduling races (#61050) and fundamental issues with the affinity terms it creates (#61410)

As such, there is not significant value in having the feature available in 1.10 in the current state

This PR disables the feature in order to regain green signal on the alpha CI job (reverting commits is likely to be more disruptive at this point)

related to #61050

DaemonSet scheduling associated with the alpha ScheduleDaemonSetPods feature flag has been removed from the 1.10 release. See https://github.com/kubernetes/features/issues/548 for feature status.
@k82cn

This comment has been minimized.

Copy link
Member

k82cn commented Mar 20, 2018

/lgtm

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Mar 20, 2018

/kind bug
/priority critical-urgent
/sig scheduling

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Mar 20, 2018

/sig apps

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Mar 20, 2018

/sig release

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Mar 20, 2018

/retest

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Mar 20, 2018

/retest

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Mar 20, 2018

/status approved-for-milestone

@deads2k

This comment has been minimized.

Copy link
Contributor

deads2k commented Mar 20, 2018

/approve

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Mar 20, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@bsalamat @k82cn @liggitt

Pull Request Labels
  • sig/apps sig/release sig/scheduling: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, k82cn, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bsalamat

This comment has been minimized.

Copy link
Contributor

bsalamat commented Mar 20, 2018

Given that we are way overdue for this release and the alpha cluster tests are not passing yet, I think this is the right decision. Next time we must ensure that such big changes are merged at least one week before the code freeze to allow fixing possible test failures.

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Mar 20, 2018

/retest

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Mar 20, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Mar 20, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit a64a11d into kubernetes:master Mar 20, 2018

13 of 14 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

k8s-github-robot pushed a commit that referenced this pull request Mar 21, 2018

Kubernetes Submit Queue
Merge pull request #61412 from liggitt/automated-cherry-pick-of-#6141…
…1-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #61411: disable DaemonSet scheduling feature for 1.10

Cherry pick of #61411 on release-1.10.

related to #61050

#61411: disable DaemonSet scheduling feature for 1.10

```release-note
DaemonSet scheduling associated with the alpha ScheduleDaemonSetPods feature flag has been removed from the 1.10 release. See kubernetes/enhancements#548 for feature status.
```

@liggitt liggitt deleted the liggitt:remove-ds-scheduling branch Apr 2, 2018

@redbaron

This comment has been minimized.

Copy link
Contributor

redbaron commented Jun 28, 2018

This PR is mentioned in Changelog 1.11

DaemonSet scheduling associated with the alpha ScheduleDaemonSetPods feature flag has been emoved. See kubernetes/enhancements#548 for feature status. (#61411, @liggitt)

But it seems to be exactly opposite, featuregate was added: kubernetes/website#8842

@janetkuo

This comment has been minimized.

Copy link
Member

janetkuo commented Jun 29, 2018

@calebamiles this PR targets 1.10 instead of 1.11. I was wondering if there's any other release note that got misplaced.

@embano1

This comment has been minimized.

Copy link

embano1 commented Jul 2, 2018

Yes, it's slightly confusing but note that it is flagged under Removed Deprecations, i.e. it has been reverted. This is how I read it, based on @k82cn work.

@janetkuo

This comment has been minimized.

Copy link
Member

janetkuo commented Jul 2, 2018

@embano1 IIUC "Removed Deprecations" stands for the removal of a deprecated feature (e.g. flags, API fields, etc.), meaning that the feature itself was removed. The revert of "a revert of a feature" (i.e. add a feature) shouldn't belong there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.