Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Schedule even if extender is not available when using extender #61445
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
TODO: update the examples in kubernetes/examples, but the strategy there is not clear to me for now
2 times, most recently
Mar 21, 2018
ravisantoshgudimetla left a comment
@resouer Thanks for working on this. Looks very good, except for nits. This addresses the issue I created. One thing to note is we can log the warning here itself.
Yes, if you mean adding the warning at "https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/core/extender.go#L388", I think it would be better because we are capturing error at the source rather than place where we are calling it from.
In that case, if the extender failed with errors other than
It shouldn't as we would still have
@resouer: The following test failed, say
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing