Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
implement glusterfs volume plugin #6174
I think we need to talk more about helper field before this merges.
We met and discussed this PR. rootfs and steve watt explained goal to run glusterfs easily on OSes that don't include glusterfs fuse daemon, such as RH Atomic. Vish and I liked the idea of a fuse daemon per pod, but didn't like the idea of the user providing part of the command line for a root binary. So, we agreed to remove Helper field from this PR, and try to cooperate to find a way to accomplish the goal another way in a future PR. That seemed to depend in part on a little clearer picture of how glusterfs file tree is to be mapped into pods (e.g. do all pods see whole file tree, or subset that is different per pod), and how this interacts with Claims.
Anyhow It looks like Helper is gone, so this LGTM. I still will let Vish have a final look.