New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ObjectMeta and *Options from core api #61809

Merged
merged 1 commit into from Apr 9, 2018

Conversation

@hzxuzhonghu
Member

hzxuzhonghu commented Mar 28, 2018

remove ObjectMeta and *Options from core api

Fixes #61807

Special notes for your reviewer:

Release note:

Remove `ObjectMeta ` `ListOptions` `DeleteOptions` from core api group.  Please use that in meta/v1
@hzxuzhonghu

This comment has been minimized.

Member

hzxuzhonghu commented Mar 28, 2018

@hzxuzhonghu

This comment has been minimized.

Member

hzxuzhonghu commented Mar 29, 2018

/assign @deads2k

@@ -155,7 +155,7 @@ func TestDefaulting(t *testing.T) {
c.FuzzNoCustom(s)
s.MatchExpressions = nil // need to fuzz this specially
},
func(s *apiv1.ListOptions, c fuzz.Continue) {
func(s *metav1.ListOptions, c fuzz.Continue) {

This comment has been minimized.

@deads2k

deads2k Mar 29, 2018

Contributor

check for an existing fuzzer in apimachinery for this

@deads2k

This comment has been minimized.

Contributor

deads2k commented Mar 29, 2018

comment on test, squash the generated changes into a single generation commit.

@smarterclayton for approval

@hzxuzhonghu

This comment has been minimized.

Member

hzxuzhonghu commented Mar 30, 2018

squashed

@hzxuzhonghu

This comment has been minimized.

Member

hzxuzhonghu commented Apr 4, 2018

ping @smarterclayton for approval

@smarterclayton

This comment has been minimized.

Contributor

smarterclayton commented Apr 4, 2018

/approve

@hzxuzhonghu

This comment has been minimized.

Member

hzxuzhonghu commented Apr 9, 2018

@deads2k need a lgtm tag

@deads2k

This comment has been minimized.

Contributor

deads2k commented Apr 9, 2018

/lgtm
/hold

holding for squash, feel free to remove after squashing.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Apr 9, 2018

@hzxuzhonghu

This comment has been minimized.

Member

hzxuzhonghu commented Apr 9, 2018

Done

@hzxuzhonghu

This comment has been minimized.

Member

hzxuzhonghu commented Apr 9, 2018

/hold cancel

@deads2k

This comment has been minimized.

Contributor

deads2k commented Apr 9, 2018

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 9, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Apr 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, hzxuzhonghu, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

fejta-bot commented Apr 9, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 9, 2018

Automatic merge from submit-queue (batch tested with PRs 60692, 61809). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 7931930 into kubernetes:master Apr 9, 2018

15 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation hzxuzhonghu authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@hzxuzhonghu hzxuzhonghu deleted the hzxuzhonghu:corev1-api-delete branch Apr 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment