New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated ExternalID #61877

Merged
merged 4 commits into from Apr 19, 2018

Conversation

@mikedanese
Member

mikedanese commented Mar 29, 2018

This field has been deprecated since 1.1. After we remove it we can remove "self delete" from the node's permission set.

@kubernetes/api-reviewers
@kubernetes/sig-auth-pr-reviews

fixes #61966
part of kubernetes/community#911

Kubelets will no longer set `externalID` in their node spec.
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Apr 18, 2018

@mikedanese: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-100-performance 55a2f06 link /test pull-kubernetes-e2e-gce-100-performance

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikedanese

This comment has been minimized.

Member

mikedanese commented Apr 18, 2018

/retest

@liggitt

This comment has been minimized.

Member

liggitt commented Apr 18, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 18, 2018

@tallclair

This comment has been minimized.

Member

tallclair commented Apr 18, 2018

/lgtm

@mikedanese

This comment has been minimized.

Member

mikedanese commented Apr 18, 2018

@dims for cinder approval

@dims

This comment has been minimized.

Member

dims commented Apr 18, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Apr 18, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, mikedanese, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 19, 2018

Automatic merge from submit-queue (batch tested with PRs 62481, 62643, 61877, 62515). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit efadf7b into kubernetes:master Apr 19, 2018

15 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation mikedanese authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@mikedanese mikedanese deleted the mikedanese:depeid branch Apr 19, 2018

@jingxu97

This comment has been minimized.

Contributor

jingxu97 commented on pkg/kubelet/kubelet_node_status.go in d02cf10 May 10, 2018

Why remove this logic? If node was previously registered with the same name, but the node is a new instances (different providerID or externalID). In this case, I think it is better to delete the old API object, and create a new one. Otherwise, there might be some stale information from the old object. For example, which volumes are attached to this node.

This comment has been minimized.

Member

mikedanese replied May 11, 2018

We are trying to remove the kubelet's permission to delete itself as it poses a security risk. kubernetes/community#911

zachaller added a commit to zachaller/kops that referenced this pull request May 16, 2018

@DirectXMan12 DirectXMan12 referenced this pull request Jun 14, 2018

Merged

Rebase 3.11 beta2 #59

0 of 7 tasks complete

k8s-merge-robot added a commit that referenced this pull request Jul 28, 2018

Merge pull request #66593 from stewart-yu/stewart-kubelet-commentclean
Automatic merge from submit-queue (batch tested with PRs 66593, 66727, 66558). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

remove the outdate comments in tryRegisterWithAPIServer

**What this PR does / why we need it**:
some judgement about ExternalID removed in #61877, so remove the outdate comments in tryRegisterWithAPIServer


**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

bigkraig added a commit to kubernetes-sigs/aws-alb-ingress-controller that referenced this pull request Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment