Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
remove deprecated ExternalID #61877
requested review from
Mar 29, 2018
@mikedanese: The following test failed, say
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
Apr 19, 2018
15 checks passed
referenced this pull request
Apr 20, 2018
Why remove this logic? If node was previously registered with the same name, but the node is a new instances (different providerID or externalID). In this case, I think it is better to delete the old API object, and create a new one. Otherwise, there might be some stale information from the old object. For example, which volumes are attached to this node.