Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Istio addon to 0.6.0 and mirror images in gcr #61911

Merged
merged 2 commits into from Apr 17, 2018

Conversation

@ostromart
Copy link
Contributor

ostromart commented Mar 29, 2018

What this PR does / why we need it:
PR addresses two issues:

  1. Update Istio addon version to latest stable 0.6.0 (required for e2e test integration).
  2. Mirror images in gcr.io for security scanning, since this is an addon.

Fixes #61910

Release note:

Update version of Istio addon from 0.5.1 to 0.6.0.
See https://istio.io/about/notes/0.6.html for full Isto release notes.
@ostromart

This comment has been minimized.

Copy link
Contributor Author

ostromart commented Mar 29, 2018

/sig cluster-lifecycle

@ostromart ostromart force-pushed the ostromart:istio_update_version branch from 831021a to 7d86ef8 Mar 29, 2018

@ostromart

This comment has been minimized.

Copy link
Contributor Author

ostromart commented Mar 29, 2018

/assign @cjcullen

@@ -8,6 +8,7 @@ kind: Namespace
metadata:
name: istio-system
labels:
istio-injection: enabled

This comment has been minimized.

@yusuoh

yusuoh Mar 29, 2018

This should not be applied to istio-system namespace. It should be applied to the "default" namespace.

This comment has been minimized.

@ostromart

ostromart Mar 30, 2018

Author Contributor

Done.

@ostromart ostromart force-pushed the ostromart:istio_update_version branch from 84b44bd to c9a71a6 Mar 30, 2018

name: default
labels:
istio-injection: enabled
addonmanager.kubernetes.io/mode: Reconcile

This comment has been minimized.

@yusuoh

yusuoh Mar 30, 2018

Will this prevent users to add other labels to default namespace?

This comment has been minimized.

@ostromart

ostromart Mar 30, 2018

Author Contributor

No, only items explicitly set in the yaml are reconciled (so you only cannot remove this label). Users are free to add anything not listed in the yaml.

group: config.istio.io
names:
kind: solarwinds
plural: solarwindses

This comment has been minimized.

@cjcullen

cjcullen Apr 3, 2018

Member

This is weird plural :).

This comment has been minimized.

@ostromart

ostromart Apr 3, 2018

Author Contributor

I think it's middle earth english - one hobbit, two hobbitses.

@cjcullen

This comment has been minimized.

Copy link
Member

cjcullen commented Apr 3, 2018

The container image updates look fine to me, but this PR does a bunch of other stuff as well. I'd like somebody working on Istio to give this an LGTM too.

@cjcullen

This comment has been minimized.

Copy link
Member

cjcullen commented Apr 3, 2018

/ok-to-test

@ostromart

This comment has been minimized.

Copy link
Contributor Author

ostromart commented Apr 3, 2018

@yusuoh works on Istio. Are you looking for someone in a specific function?
btw. This yaml is a slightly modified version of https://github.com/istio/istio/releases/ 0.6. The differences are:

  • k8s addon specific labels added for addon manager
  • images come from gcr.io
  • all istio extensions (prom, zipkin etc) are installed
@ostromart

This comment has been minimized.

Copy link
Contributor Author

ostromart commented Apr 4, 2018

/retest

@cjcullen

This comment has been minimized.

Copy link
Member

cjcullen commented Apr 5, 2018

I'm fine adding the official LGTM if @yusuoh says it looks good.

@ostromart

This comment has been minimized.

Copy link
Contributor Author

ostromart commented Apr 5, 2018

@yusuoh is OOO till monday. I'm pretty sure he's ok with this going in as we are working on it together (he sits next to me). But if you don't feel comfortable with that I understand. We can alternatively look for someone else to give another lgtm.

@yusuoh

This comment has been minimized.

Copy link

yusuoh commented Apr 10, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 10, 2018

@yusuoh: changing LGTM is restricted to assignees, and only kubernetes org members may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ostromart

This comment has been minimized.

Copy link
Contributor Author

ostromart commented Apr 10, 2018

could you please go ahead and lgtm the merge @cjcullen ?

@cjcullen

This comment has been minimized.

Copy link
Member

cjcullen commented Apr 12, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 12, 2018

@ostromart

This comment has been minimized.

Copy link
Contributor Author

ostromart commented Apr 13, 2018

/test pull-kubernetes-e2e-gce

@cjcullen

This comment has been minimized.

Copy link
Member

cjcullen commented Apr 13, 2018

/approve

@cjcullen

This comment has been minimized.

Copy link
Member

cjcullen commented Apr 14, 2018

@zmerlynn can you approve?

@krzyzacy

This comment has been minimized.

Copy link
Member

krzyzacy commented Apr 16, 2018

/assign @mikedanese
@zmerlynn is OOO, Mike can you give an approval here?

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 16, 2018

@ostromart: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-100-performance c9a71a6 link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-kubemark-e2e-gce-big c9a71a6 link /test pull-kubernetes-kubemark-e2e-gce-big

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikedanese

This comment has been minimized.

Copy link
Member

mikedanese commented Apr 16, 2018

/retest

@krzyzacy

This comment has been minimized.

Copy link
Member

krzyzacy commented Apr 16, 2018

(tests passed)

@mikedanese

This comment has been minimized.

Copy link
Member

mikedanese commented Apr 17, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjcullen, mikedanese, ostromart, yusuoh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Apr 17, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Apr 17, 2018

Automatic merge from submit-queue (batch tested with PRs 57224, 61911). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 28f9356 into kubernetes:master Apr 17, 2018

8 of 17 checks passed

pull-kubernetes-e2e-gce-100-performance Job failed.
Details
pull-kubernetes-kubemark-e2e-gce-big Job failed.
Details
Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job triggered.
Details
pull-kubernetes-e2e-kops-aws Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce Job triggered.
Details
pull-kubernetes-node-e2e Job triggered.
Details
pull-kubernetes-verify Job triggered.
Details
cla/linuxfoundation ostromart authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-typecheck Job succeeded.
Details

@ostromart ostromart deleted the ostromart:istio_update_version branch Apr 17, 2018

@ostromart

This comment has been minimized.

Copy link
Contributor Author

ostromart commented Apr 18, 2018

/cherrypick-candidate

k8s-github-robot pushed a commit that referenced this pull request Apr 26, 2018

Kubernetes Submit Queue
Merge pull request #62813 from ostromart/automated-cherry-pick-of-#61…
…911-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #61911 upstream release 1.10

**What this PR does / why we need it:**
PR addresses two issues:
1. Update Istio addon version to latest stable 0.6.0 (required for e2e test integration).
2. Mirror images in gcr.io for security scanning, since this is an addon.

Fixes #61910 

**Release note**:
```release-note
Update version of Istio addon from 0.5.1 to 0.6.0.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.