Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRI: update documents for container logpath #62015

Merged
merged 1 commit into from May 15, 2018

Conversation

Projects
None yet
5 participants
@feiskyer
Copy link
Member

feiskyer commented Apr 2, 2018

What this PR does / why we need it:

The container log path has been changed from containername_attempt#.log to containername/attempt#.log in #59906. This PR updates CRI documents for it.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

CRI: update documents for container logpath. The container log path has been changed from containername_attempt#.log to containername/attempt#.log 
@feiskyer

This comment has been minimized.

Copy link
Member Author

feiskyer commented Apr 24, 2018

@feiskyer

This comment has been minimized.

Copy link
Member Author

feiskyer commented May 8, 2018

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented May 14, 2018

Thanks! lgtm

Can you add a release note so we can patch 1.10?

@feiskyer

This comment has been minimized.

Copy link
Member Author

feiskyer commented May 15, 2018

@yujuhong release note added. PTAL

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented May 15, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 15, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 15, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 15, 2018

Automatic merge from submit-queue (batch tested with PRs 63603, 63557, 62015). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit b71966a into kubernetes:master May 15, 2018

15 of 16 checks passed

pull-kubernetes-local-e2e-containerized Job triggered.
Details
Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation feiskyer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@feiskyer feiskyer deleted the feiskyer:container-log branch May 15, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 25, 2018

@feiskyer: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e-containerized 038af53 link /test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.