Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds initial Korean translations for kubectl #62040

Merged
merged 1 commit into from May 14, 2018

Conversation

@ianychoi
Copy link
Member

ianychoi commented Apr 2, 2018

What this PR does / why we need it:
This PR provides a first attempt to translate kubectl in Korean (related to #51867, #40645, #45573, #45562, #40591, #46559, #50155).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
No issues

Special notes for your reviewer:
This PR requires Korean people to assist in the review. I am native in Korean and also a translator & reviewer in Korean in OpenStack I18n team (http://stackalytics.com/?metric=translations&user_id=ianychoi ).

Release note:

Adding initial Korean translation for kubectl
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 2, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

"watch is only supported on individual resources and resource collections - "
"%d resources were found"
msgstr[0] ""
"watch는 단일 리소스와 리소스 모음만을 지원합니다 - %d 개 자원을 발견하였습"

This comment has been minimized.

@yue9944882

yue9944882 Apr 3, 2018

Member

Typo. Plz join these 2 lines.

This comment has been minimized.

@ianychoi

ianychoi Apr 3, 2018

Author Member

@yue9944882 That's because it is recommended to wrap lines at column 80. Would it be okay?

[1] http://pology.nedohodnik.net/doc/user/en_US/ch-poformat.html

This comment has been minimized.

@yue9944882

yue9944882 Apr 3, 2018

Member

It's okay. I looks shorter than L85 tho. Maybe due to github displaying problem.

@gochist

This comment has been minimized.

Copy link
Member

gochist commented Apr 10, 2018

/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 10, 2018

@gochist: you can't request testing unless you are a kubernetes member.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yue9944882

This comment has been minimized.

Copy link
Member

yue9944882 commented Apr 11, 2018

/ok-to-test

@yue9944882

This comment has been minimized.

Copy link
Member

yue9944882 commented Apr 11, 2018

/lgtm

Hoping more commands could be translated in the future :)

@ianychoi

This comment has been minimized.

Copy link
Member Author

ianychoi commented Apr 19, 2018

/retest

@yue9944882

This comment has been minimized.

Copy link
Member

yue9944882 commented Apr 19, 2018

/cc @dchen1107 @kubernetes/sig-cli-maintainers Do you think about approving this PR plz?

@soltysh

This comment has been minimized.

Copy link
Contributor

soltysh commented Apr 19, 2018

@yue9944882 I can approve the kubectl part (although I defer to your lgtm on the correctness of this PR), yet you'll need top-level approval as well.

/approve

@ianychoi ianychoi force-pushed the ianychoi:korean-translation branch from a6e93db to 856110a May 12, 2018

@yue9944882

This comment has been minimized.

Copy link
Member

yue9944882 commented May 14, 2018

/test pull-kubernetes-e2e-gce

@yue9944882

This comment has been minimized.

Copy link
Member

yue9944882 commented May 14, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 14, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 14, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ianychoi, soltysh, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 14, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 14, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit e24fd8e into kubernetes:master May 14, 2018

15 of 16 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation ianychoi authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.