New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incompatible file type checking on Windows #62154

Merged
merged 2 commits into from Apr 10, 2018

Conversation

@dixudx
Member

dixudx commented Apr 5, 2018

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #62121

Special notes for your reviewer:
/cc @msau42 @jsafrane
/assign @andyzhangx

Release note:

fix incompatible file type checking on Windows
@andyzhangx

This comment has been minimized.

Member

andyzhangx commented Apr 5, 2018

/sig storage
/sig windows

@andyzhangx

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 5, 2018

return mode&targetMode == targetMode
}
mode := info.Mode()

This comment has been minimized.

@msau42

msau42 Apr 5, 2018

Member

Can this be done for linux too?

This comment has been minimized.

@dixudx

dixudx Apr 8, 2018

Member

Yes. Works for linux as well. Will create a common function for use.

@k8s-ci-robot k8s-ci-robot added size/L and removed lgtm size/S labels Apr 8, 2018

@dixudx

This comment has been minimized.

Member

dixudx commented Apr 8, 2018

exit status 1: mknod: '/tmp/test-get-filetype-289417242/test_char_dev': Operation not permitted

These tests got passed locally. Seems the CI is not friendly to such operations.
@msau42 Shall we omit such error?

@jsafrane

This comment has been minimized.

Member

jsafrane commented Apr 9, 2018

/approve

@msau42

This comment has been minimized.

Member

msau42 commented Apr 9, 2018

These tests got passed locally. Seems the CI is not friendly to such operations.

Yeah, let's leave it out, it can be covered in an e2e.

@dixudx

This comment has been minimized.

Member

dixudx commented Apr 10, 2018

Yeah, let's leave it out

@msau42 @andyzhangx Leave that error out. PTAL. Thanks.

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 10, 2018

@andyzhangx

/lgtm

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Apr 10, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, dixudx, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dixudx

This comment has been minimized.

Member

dixudx commented Apr 10, 2018

/retest

@fejta-bot

This comment has been minimized.

fejta-bot commented Apr 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot

This comment has been minimized.

fejta-bot commented Apr 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 10, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 10, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 77d18db into kubernetes:master Apr 10, 2018

14 of 15 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation dixudx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@dixudx dixudx deleted the dixudx:fix-hostpath-type-windows branch Apr 11, 2018

@andyzhangx

This comment has been minimized.

Member

andyzhangx commented Apr 12, 2018

hi @dixudx is it possible to also add nsenter_mount unit test for function like PathIsDevice? I just found a critcal bug in containerized kubelet which would cause UnmountDevice failed for all pods with volume mount,

@dixudx

This comment has been minimized.

Member

dixudx commented Apr 12, 2018

@andyzhangx Have you tried the master branch? Or related to #61802?

k8s-merge-robot added a commit that referenced this pull request Apr 13, 2018

Merge pull request #62364 from dixudx/automated-cherry-pick-of-#62154-…
…upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #62154: fix incompatible file type checking on Windows

Cherry pick of #62154 on release-1.10.

#62154: fix incompatible file type checking on Windows

k8s-merge-robot added a commit that referenced this pull request Apr 13, 2018

Merge pull request #62365 from dixudx/automated-cherry-pick-of-#62154-…
…upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #62154: fix incompatible file type checking on Windows

Cherry pick of #62154 on release-1.9.

#62154: fix incompatible file type checking on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment