Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug for regular empty file #62159

Merged
merged 1 commit into from May 28, 2019

Conversation

@dixudx
Copy link
Member

commented Apr 5, 2018

What this PR does / why we need it:
For an empty regular file, stat --printf %F will display regular empty file instead of regular file.

This is a potential bug.
/kind bug

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #64522

Special notes for your reviewer:
/cc @jsafrane @msau42
Release note:

fix bug for regular empty file
pkg/util/mount/nsenter_mount.go Outdated Show resolved Hide resolved
@fejta-bot

This comment has been minimized.

Copy link

commented Aug 29, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@dixudx

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2018

/remove-lifecycle stale

@fejta-bot

This comment has been minimized.

Copy link

commented Nov 29, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@dixudx

This comment has been minimized.

Copy link
Member Author

commented Nov 30, 2018

/remove-lifecycle stale

@oomichi

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

This change itself seems good for me, because I can see the result of stat command like

$ touch foo
$ stat --printf %F foo
regular empty file
@oomichi

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

/cc @oomichi

@k8s-ci-robot k8s-ci-robot requested a review from oomichi Feb 19, 2019

@dixudx

This comment has been minimized.

Copy link
Member Author

commented Feb 20, 2019

Thanks @oomichi for helping verified this. Currently we don't have a containerized CI test. @msau42
Shall we get this merged first?

@dixudx

This comment has been minimized.

Copy link
Member Author

commented Feb 20, 2019

/retest

@oomichi

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

/lgtm

@fejta-bot

This comment has been minimized.

Copy link

commented May 24, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@dixudx

This comment has been minimized.

Copy link
Member Author

commented May 27, 2019

/remove-lifecycle stale

@dixudx dixudx force-pushed the dixudx:fix_nsenter_file_type branch from 46e0fe4 to f715d41 May 27, 2019

@k8s-ci-robot k8s-ci-robot added sig/storage and removed lgtm labels May 27, 2019

@jsafrane

This comment has been minimized.

Copy link
Member

commented May 27, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented May 27, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot

This comment has been minimized.

Copy link

commented May 27, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

commented May 28, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@dixudx

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

commented May 28, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit ec89794 into kubernetes:master May 28, 2019

20 checks passed

cla/linuxfoundation dixudx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@dixudx dixudx deleted the dixudx:fix_nsenter_file_type branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.