New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the issue that default azure disk fsypte(ext4) does not work on Windows #62250

Merged
merged 1 commit into from Apr 8, 2018

Conversation

Projects
None yet
5 participants
@andyzhangx
Member

andyzhangx commented Apr 8, 2018

What this PR does / why we need it:
This line of code will set default fstype as ext4 which is not applicable for Windows disk.
This PR remove the default fstype setting from master side.
We should leave fstype in master as what it is, and let client side(kubelet) decide the default fstype:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #62247

Special notes for your reviewer:

Release note:

fix the issue that default azure disk fsypte(ext4) does not work on Windows

/sig azure
/sig windows
@feiskyer @karataliu

@@ -121,7 +121,6 @@ func (p *azureDiskProvisioner) Provision() (*v1.PersistentVolume, error) {
}
// normalize values
fsType = normalizeFsType(fsType)

This comment has been minimized.

@feiskyer

feiskyer Apr 8, 2018

Member

Has been defaultFSType set elsewhere?

This comment has been minimized.

@andyzhangx

andyzhangx Apr 8, 2018

Member

@feiskyer We should leave fstype in master as what it is, and set in kubelet:

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Apr 8, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 8, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 8, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 66ef4c0 into kubernetes:master Apr 8, 2018

14 of 15 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation andyzhangx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

k8s-merge-robot added a commit that referenced this pull request Apr 17, 2018

Merge pull request #62625 from andyzhangx/automated-cherry-pick-of-#6…
…2250-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #62250: remove default fsypte in azure disk

Cherry pick of #62250 on release-1.9.

#62250: remove default fsypte in azure disk

k8s-merge-robot added a commit that referenced this pull request Apr 18, 2018

Merge pull request #62616 from andyzhangx/automated-cherry-pick-of-#6…
…2250-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #62250: remove default fsypte in azure disk

Cherry pick of #62250 on release-1.10.

#62250: remove default fsypte in azure disk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment