Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate InfluxDB cluster monitoring #62328

Merged
merged 1 commit into from May 16, 2018

Conversation

@serathius
Copy link
Contributor

serathius commented Apr 10, 2018

InfluxDB cluster monitoring addon will no longer be supported and will be removed in k8s 1.12.
Default monitoring solution will be changed to standalone.
Heapster will still be deployed for backward compatibility of kubectl top

Stop using InfluxDB as default cluster monitoring
InfluxDB cluster monitoring is deprecated and will be removed in v1.12

cc @piosz

@piosz

This comment has been minimized.

Copy link
Member

piosz commented Apr 10, 2018

/ok-to-test

@serathius serathius force-pushed the serathius:monitoring-default-none branch from 94aae9c to 9869d5b Apr 10, 2018

@k8s-ci-robot k8s-ci-robot added size/L and removed size/XS labels Apr 10, 2018

@serathius serathius changed the title Don't deploy cluster monitoring by default Deprecate InfluxDB cluster monitoring Apr 10, 2018

@serathius

This comment has been minimized.

Copy link
Contributor Author

serathius commented Apr 12, 2018

@kawych

This comment has been minimized.

Copy link
Contributor

kawych commented Apr 12, 2018

I'm fine with changing the default, but should we delete e2e tests already? I would prefer to remove them only when we actually stop supporting influxdb.

@serathius serathius force-pushed the serathius:monitoring-default-none branch from 9869d5b to 004b239 Apr 13, 2018

@k8s-ci-robot k8s-ci-robot added size/S and removed size/L labels Apr 13, 2018

@serathius

This comment has been minimized.

Copy link
Contributor Author

serathius commented Apr 13, 2018

I tagged tests with [Feature:InfluxdbMonitoring] so we can create separate test suite and still run them periodically.

@kawych

This comment has been minimized.

Copy link
Contributor

kawych commented Apr 13, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 13, 2018

@serathius serathius force-pushed the serathius:monitoring-default-none branch from 004b239 to c4cb04a Apr 18, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Apr 18, 2018

@serathius

This comment has been minimized.

Copy link
Contributor Author

serathius commented Apr 18, 2018

rebased

@serathius serathius force-pushed the serathius:monitoring-default-none branch from c4cb04a to c21aeac Apr 19, 2018

@kawych

This comment has been minimized.

Copy link
Contributor

kawych commented Apr 20, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 20, 2018

@serathius

This comment has been minimized.

Copy link
Contributor Author

serathius commented May 14, 2018

/assign @DirectXMan12

@serathius

This comment has been minimized.

Copy link
Contributor Author

serathius commented May 15, 2018

/cc @brancz

@k8s-ci-robot k8s-ci-robot requested a review from brancz May 15, 2018

@brancz

This comment has been minimized.

Copy link
Member

brancz commented May 15, 2018

Generally this sounds and looks good to me, I'm just wondering about this sentence:

Heapster will still be deployed for backward compatibility of kubectl top

Are you talking about older versions? In 1.10+ kubectl top defaults to using the resource metrics API and only falls back to trying heapster.

@serathius

This comment has been minimized.

Copy link
Contributor Author

serathius commented May 16, 2018

Are you talking about older versions? In 1.10+ kubectl top defaults to using the resource metrics API and only falls back to trying heapster.

Yes, that's why we don't want drop heapster in following version 1.11, not everyone had chance to upgrade their client. We don't want to drop kubectl 1.10 support for metrics in default configuration.

Instead defaulting to none we will default to standalone to give people time to upgrade their kubectl.

@brancz

This comment has been minimized.

Copy link
Member

brancz commented May 16, 2018

Got it. Thanks for clarifying.

/approve
/lgtm

@serathius

This comment has been minimized.

Copy link
Contributor Author

serathius commented May 16, 2018

@wojtek-t can you approve please?

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented May 16, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, kawych, serathius, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 16, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 16, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 5686fcf into kubernetes:master May 16, 2018

15 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation serathius authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.