New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "git: Use VolumeHost.GetExec() to execute stuff in volume plugins" #62394

Merged
merged 1 commit into from Apr 13, 2018

Conversation

Projects
None yet
5 participants
@jsafrane
Member

jsafrane commented Apr 11, 2018

This reverts commit c578542 (PR #51098). The PR added support for containerized git, on the other hand it required git 1.8.5. This breaks git volumes on older distros (CentOS 7, Ubuntu 14.04) that have old git.

Git volumes are getting deprecated (#60999) so we should restore it to the last working state and not touch it any longer.

Release note:

gitRepo volumes in pods no longer require git 1.8.5 or newer, older git versions are supported too now.

I'd like to cherry-pick it into 1.10.

/sig storage

Revert "git: Use VolumeHost.GetExec() to execute stuff in volume plug…
…ins"

This reverts commit c578542.

Older distros (centos 7, ubuntu 14.04) use older git than required by
the reverted patch.
@jsafrane

This comment has been minimized.

Member

jsafrane commented Apr 12, 2018

/retest

@jsafrane

This comment has been minimized.

Member

jsafrane commented Apr 12, 2018

@rootfs, you reviewed the original PR, can you please look at this one?

@jsafrane

This comment has been minimized.

Member

jsafrane commented Apr 12, 2018

@saad-ali, this is another thing that I'd like to fix in 1.10.x - I give up with mount container for git, it's deprecated and users can use init containers with the same effect. So let's roll back my changes, make git volume working everywhere and don't touch it.

@jsafrane

This comment has been minimized.

Member

jsafrane commented Apr 13, 2018

/assign @rootfs

@childsb

This comment has been minimized.

Member

childsb commented Apr 13, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Apr 13, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 13, 2018

Automatic merge from submit-queue (batch tested with PRs 60476, 62462, 61391, 62535, 62394). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 3e4268f into kubernetes:master Apr 13, 2018

15 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation jsafrane authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

k8s-merge-robot added a commit that referenced this pull request Apr 18, 2018

Merge pull request #62622 from jsafrane/automated-cherry-pick-of-#62394
…-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #62394: Revert "git: Use VolumeHost.GetExec() to execute stuff in

Cherry pick of #62394 on release-1.10.

#62394: Revert "git: Use VolumeHost.GetExec() to execute stuff in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment