New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix machineID getting for vmss nodes when using instance metadata #62611

Merged
merged 1 commit into from Apr 16, 2018

Conversation

Projects
None yet
5 participants
@feiskyer
Member

feiskyer commented Apr 16, 2018

What this PR does / why we need it:

When instancemetadata is for Kubelet on master nodes , kubelet is not able to register itself with errors:

Unable to construct v1.Node object for kubelet: failed to get external ID from cloud provider: not a vmss instance

This PR fixes this issue by composing standard instance ID for such nodes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #62610

Special notes for your reviewer:

Need cherry pick to 1.10.

Release note:

Fix machineID getting for vmss nodes when using instance metadata

/assign @andyzhangx

@andyzhangx

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 16, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Apr 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer

This comment has been minimized.

Member

feiskyer commented Apr 16, 2018

/retest

1 similar comment
@feiskyer

This comment has been minimized.

Member

feiskyer commented Apr 16, 2018

/retest

@fejta-bot

This comment has been minimized.

fejta-bot commented Apr 16, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 16, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 16, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 5e50a0f into kubernetes:master Apr 16, 2018

14 of 15 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation feiskyer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@sozercan sozercan referenced this pull request Apr 16, 2018

Merged

VirtualMachineScaleSets support for Kubernetes #2620

3 of 3 tasks complete

@feiskyer feiskyer deleted the feiskyer:vmss-standard branch Apr 17, 2018

k8s-merge-robot added a commit that referenced this pull request Apr 20, 2018

Merge pull request #62688 from feiskyer/automated-cherry-pick-of-#62611
…-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #62611: Fix machineID getting for vmss nodes when using instance

Cherry pick of #62611 on release-1.10.

#62611: Fix machineID getting for vmss nodes when using instance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment