New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all script shebangs to use /usr/bin/env interpreter instead of /bin/interpreter #62657

Merged
merged 1 commit into from May 3, 2018

Conversation

Projects
None yet
8 participants
@matthyx
Contributor

matthyx commented Apr 16, 2018

This is required to support systems where bash doesn't reside in /bin (such as NixOS, or the *BSD family) and allow users to specify a different interpreter version through $PATH manipulation.
https://www.cyberciti.biz/tips/finding-bash-perl-python-portably-using-env.html

Use /usr/bin/env in all script shebangs to increase portability.
@cblecker

This comment has been minimized.

Member

cblecker commented Apr 16, 2018

@matthyx Please remove all changes to examples/ as we are phasing out this dir. You can make any related changes directly to https://github.com/kubernetes/examples

@cblecker

This comment has been minimized.

Member

cblecker commented Apr 16, 2018

Also, please remove all changes in vendor/.

@matthyx

This comment has been minimized.

Contributor

matthyx commented Apr 16, 2018

@cblecker done. Thanks.

@cblecker

This comment has been minimized.

Member

cblecker commented Apr 16, 2018

/ok-to-test

@cblecker

This comment has been minimized.

Member

cblecker commented Apr 19, 2018

The pull-kubernetes-local-e2e-containerized failure is known and can be ignored.

/cc @stevekuznetsov @ixdy
Hey Steve/Jeff.. any concerns with this? I think this is a good change, but dunno if either of you have run into oddities doing this.

@k8s-ci-robot k8s-ci-robot requested review from ixdy and stevekuznetsov Apr 19, 2018

@stevekuznetsov

This comment has been minimized.

Contributor

stevekuznetsov commented Apr 19, 2018

Seems reasonable but may cause weirdness if anyone's got some other bash installed and it comes earlier than /bin/bash in their $PATH... which should be unlikely and someone doing something that complicated should be OK to figure out what happened.

@cblecker

This comment has been minimized.

Member

cblecker commented Apr 19, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 19, 2018

@cblecker

This comment has been minimized.

Member

cblecker commented Apr 19, 2018

/assign @lavalamp
for approval

@matthyx

This comment has been minimized.

Contributor

matthyx commented May 2, 2018

@lavalamp @cblecker should I do something about this PR before it becomes stale?

@lavalamp

This comment has been minimized.

Member

lavalamp commented May 2, 2018

/retest

@lavalamp

This comment has been minimized.

Member

lavalamp commented May 2, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented May 2, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, lavalamp, matthyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

fejta-bot commented May 2, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@ixdy

This comment has been minimized.

Member

ixdy commented May 2, 2018

/retest

@fejta-bot

This comment has been minimized.

fejta-bot commented May 2, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

fejta-bot commented May 3, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented May 3, 2018

@matthyx: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gke 9b15af1 link /test pull-kubernetes-e2e-gke

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented May 3, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit b5f61ac into kubernetes:master May 3, 2018

14 of 16 checks passed

pull-kubernetes-e2e-gke Job failed.
Details
Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation matthyx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Job succeeded.
Details
pull-kubernetes-local-e2e-containerized Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment