Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for gcloud 0.9.54 #6270

Merged
merged 1 commit into from Apr 2, 2015

Conversation

Projects
None yet
4 participants
@j3ffml
Copy link
Contributor

j3ffml commented Apr 1, 2015

Updates gke provider and e2e driver for breaking changes in gcloud 0.9.54.

cc @zmerlynn

@@ -91,6 +91,7 @@ function verify-prereqs() {
gcloud_prompt="-q"
fi
gcloud ${gcloud_prompt:-} components update preview || true

This comment has been minimized.

Copy link
@roberthbailey

roberthbailey Apr 1, 2015

Member

Remove the update preview line?

This comment has been minimized.

Copy link
@j3ffml

j3ffml Apr 1, 2015

Author Contributor

We still need the preview component for instance-groups and managed-instance-groups, which were not moved to alpha.

Host string
RepoRoot string
Provider string
GceConfig GCEConfig

This comment has been minimized.

Copy link
@roberthbailey

roberthbailey Apr 1, 2015

Member

should be named GCEConfig, as acronyms are consistent case in Go.

This comment has been minimized.

Copy link
@j3ffml

j3ffml Apr 1, 2015

Author Contributor

Done.

@j3ffml j3ffml force-pushed the j3ffml:gcloud-updates branch from 09ce235 to cfc04f4 Apr 1, 2015

@roberthbailey roberthbailey added the lgtm label Apr 1, 2015

@roberthbailey

This comment has been minimized.

Copy link
Member

roberthbailey commented Apr 1, 2015

LGTM. Assigning to @zmerlynn to merge once the Jenkins box is updated to the next release of gcloud.

@j3ffml

This comment has been minimized.

Copy link
Contributor Author

j3ffml commented Apr 1, 2015

Gcloud 0.9.54 is now live. e2e test in progress.

@zmerlynn

This comment has been minimized.

Copy link
Member

zmerlynn commented Apr 2, 2015

@jlowdermilk and I talked about this. The e2es are passing as well in GKE on the new gcloud as the old. I'm merging this slightly outside the merge window because it's when I'm available to do the Jenkins maintenance and watch it for a bit longer (and it's a quiet period otherwise).

zmerlynn added a commit that referenced this pull request Apr 2, 2015

@zmerlynn zmerlynn merged commit 1ff0a1e into kubernetes:master Apr 2, 2015

4 checks passed

Shippable Shippable builds completed
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 54.61%
Details

@j3ffml j3ffml deleted the j3ffml:gcloud-updates branch Apr 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.