Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix inter-pod anti-affinity check to consider a pod a match when all the anti-affinity terms match #62715
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
referenced this pull request
Apr 17, 2018
They are both fixing pod affinity/anti-affinity issues. One is in raw affinity/anti-affinity terms and the other is in topology terms, which will match all the affinity/anti-affinity terms in topology side.
Also the description/title of this PR is misleading. This PR is focusing more on topology side.
PR #62591 was targeting a different, but similar problem. That PR was intended to fix self-affinity issue, although I also fixed the anti-affinity issue in our slow path as well. This PR cannot be back-ported as it touches code that is mostly added in #62211. We could possibly back-port #62591, but even that one cannot be back-ported verbatim and needs changes.
This PR actually fixes the issue mentioned in the title. The anti-affinity matching algorithm had a bug. The bug was not in checking topology; it was in how we combined the results of multiple anti-affinity terms.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing