Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset resultRun to 0 on pod restart #62853

Merged
merged 1 commit into from Apr 24, 2018

Conversation

@tony612
Copy link
Contributor

tony612 commented Apr 19, 2018

What this PR does / why we need it:

The resultRun should be reset to 0 on pod restart, so that resultRun on the first failure of the new container will be 1, which is correct. Otherwise, the actual FailureThreshold after restarting will be FailureThreshold - 1.

Which issue(s) this PR fixes:

This PR is related to #53530. #46371 fixed that issue but there's still a little problem like what I said above.

Special notes for your reviewer:

Release note:

fix resultRun by resetting it to 0 on pod restart
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 19, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tony612 tony612 force-pushed the tony612:fix-resultRun-reset branch from 5f4822d to b49e078 Apr 19, 2018

@tony612

This comment has been minimized.

Copy link
Contributor Author

tony612 commented Apr 19, 2018

CLA signed

@mtaufen

This comment has been minimized.

Copy link
Contributor

mtaufen commented Apr 19, 2018

/ok-to-test

@sjenning

This comment has been minimized.

Copy link
Contributor

sjenning commented Apr 19, 2018

Yes, this is a problem. Thanks for the fix!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 19, 2018

@tony612

This comment has been minimized.

Copy link
Contributor Author

tony612 commented Apr 20, 2018

/test pull-kubernetes-local-e2e-containerized

@tony612

This comment has been minimized.

Copy link
Contributor Author

tony612 commented Apr 20, 2018

I have no idea why the pull-kubernetes-local-e2e-containerized always fails. :(

@sjenning

This comment has been minimized.

@derekwaynecarr

This comment has been minimized.

Copy link
Member

derekwaynecarr commented Apr 24, 2018

/assign @derekwaynecarr

/approve
/lgtm

Thanks for the fix!

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 24, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, sjenning, tony612

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Apr 24, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 24, 2018

@tony612: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e-containerized b49e078 link /test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Apr 24, 2018

Automatic merge from submit-queue (batch tested with PRs 62655, 61711, 59122, 62853, 62390). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f68d10c into kubernetes:master Apr 24, 2018

15 of 16 checks passed

pull-kubernetes-local-e2e-containerized Job failed.
Details
Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation tony612 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.