New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Metadata Agent Config with Addon Manager #62909

Merged
merged 1 commit into from Apr 23, 2018

Conversation

@kawych
Contributor

kawych commented Apr 20, 2018

What this PR does / why we need it:
Fixes error where config map for Metadata Agent was not created by addon manager.

Release note:

Fix error where config map for Metadata Agent was not created by addon manager.
@kawych

This comment has been minimized.

Contributor

kawych commented Apr 20, 2018

@k8s-ci-robot k8s-ci-robot requested a review from piosz Apr 20, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Apr 20, 2018

@kawych: GitHub didn't allow me to request PR reviews from the following users: igorpeshansky, supriyagarg.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @piosz @igorpeshansky @supriyagarg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from lavalamp Apr 20, 2018

@kawych

This comment has been minimized.

Contributor

kawych commented Apr 20, 2018

/uncc @lavalamp

@k8s-ci-robot k8s-ci-robot removed the request for review from lavalamp Apr 20, 2018

@bmoyles0117

LGTM

@supriyagarg

LGTM

@piosz

This comment has been minimized.

Member

piosz commented Apr 23, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Apr 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kawych, piosz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 23, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 23, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 9b7439d into kubernetes:master Apr 23, 2018

14 of 15 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-kubemark-e2e-gce
Details
cla/linuxfoundation kawych authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

k8s-merge-robot added a commit that referenced this pull request Apr 24, 2018

Merge pull request #62998 from kawych/automated-cherry-pick-of-#62909-…
…upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #62909: Manage Metadata Agent Config with Addon Manager

Cherry pick of #62909 on release-1.10.

#62909: Manage Metadata Agent Config with Addon Manager

**Release note**:
```release-note
Fix error where config map for Metadata Agent was not created by addon manager.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment