Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set updated replicas #62943

Merged
merged 2 commits into from Jul 18, 2018

Conversation

@faraazkhan
Copy link
Contributor

faraazkhan commented Apr 22, 2018

What this PR does / why we need it:
Sets the .status.updatedReplicas field for stateful sets when they are being created. This behavior is consistent with how this field is handled in the deployments controller and also allows for kubectl rollout status to work when stateful sets are being created.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #52653

Special notes for your reviewer:

Release note:

fix rollout status for statefulsets
@faraazkhan

This comment has been minimized.

Copy link
Contributor Author

faraazkhan commented Apr 22, 2018

/assign smarterclayton

@faraazkhan

This comment has been minimized.

Copy link
Contributor Author

faraazkhan commented Apr 22, 2018

/sig apps

@faraazkhan faraazkhan force-pushed the faraazkhan:master branch 2 times, most recently from f094539 to 3fbe8df Apr 22, 2018

@faraazkhan

This comment has been minimized.

Copy link
Contributor Author

faraazkhan commented Apr 23, 2018

@andrewsykim are you able to /ok-to-test this?

@dims

This comment has been minimized.

Copy link
Member

dims commented Apr 23, 2018

/ok-to-test

@faraazkhan

This comment has been minimized.

Copy link
Contributor Author

faraazkhan commented Apr 23, 2018

/retest

@faraazkhan

This comment has been minimized.

Copy link
Contributor Author

faraazkhan commented Apr 23, 2018

I've had two failures now, each with a different test case. The most recent one that failed, seems to be failing for other PRs as well(example: https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/62984/pull-kubernetes-integration/7947/) , rerunning pull-kubernetes-integration to see if its reproducible. There is also this: https://github.com/kubernetes/kubernetes/pull/63017/files that might be relevant?

@faraazkhan

This comment has been minimized.

Copy link
Contributor Author

faraazkhan commented Apr 23, 2018

/test pull-kubernetes-integration

@faraazkhan faraazkhan force-pushed the faraazkhan:master branch from 3fbe8df to 8a85e9f Apr 24, 2018

@faraazkhan

This comment has been minimized.

Copy link
Contributor Author

faraazkhan commented Apr 24, 2018

/test pull-kubernetes-kubemark-e2e-gce

@@ -297,7 +297,8 @@ func (ssc *defaultStatefulSetControl) updateStatefulSet(
if isCreated(pods[i]) && !isTerminating(pods[i]) {
if getPodRevision(pods[i]) == currentRevision.Name {
status.CurrentReplicas++
} else if getPodRevision(pods[i]) == updateRevision.Name {
}
if getPodRevision(pods[i]) == updateRevision.Name {

This comment has been minimized.

@mfojtik

This comment has been minimized.

@faraazkhan

faraazkhan Apr 25, 2018

Author Contributor

Yes I will have updated PR soon. Thanks.

This comment has been minimized.

@faraazkhan

faraazkhan Apr 26, 2018

Author Contributor

@mfojtik pushed an update, PTAL

@faraazkhan faraazkhan force-pushed the faraazkhan:master branch from 8a85e9f to 594e228 Apr 26, 2018

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Apr 26, 2018

@mfojtik

This comment has been minimized.

Copy link
Contributor

mfojtik commented Apr 27, 2018

@tnozicka PTAL

@faraazkhan

This comment has been minimized.

Copy link
Contributor Author

faraazkhan commented May 8, 2018

@tnozicka @mfojtik @foxish please let me know if there is anything needed from me to move this forward.
Thank You!

@kow3ns kow3ns added this to Backlog in Workloads May 31, 2018

@kargakis

This comment has been minimized.

Copy link
Member

kargakis commented Jul 17, 2018

/lgtm
/kind bug

@kargakis

This comment has been minimized.

Copy link
Member

kargakis commented Jul 17, 2018

@smarterclayton please approve

@kargakis

This comment has been minimized.

Copy link
Member

kargakis commented Jul 17, 2018

/test all

@kargakis

This comment has been minimized.

Copy link
Member

kargakis commented Jul 17, 2018

This should be cherrypicked into older releases but I am not going to do it w/o the cherrypick robot :)

@cjwagner @BenTheElder

@smarterclayton

This comment has been minimized.

Copy link
Contributor

smarterclayton commented Jul 17, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: faraazkhan, kargakis, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@faraazkhan

This comment has been minimized.

Copy link
Contributor Author

faraazkhan commented Jul 17, 2018

/test pull-kubernetes-e2e-gce

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 18, 2018

Automatic merge from submit-queue (batch tested with PRs 66304, 62943). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 162655f into kubernetes:master Jul 18, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation faraazkhan authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

Workloads automation moved this from Backlog to Done Jul 18, 2018

@sfudeus

This comment has been minimized.

Copy link

sfudeus commented Aug 15, 2018

@kargakis You mentioned that this should be cherrypicked to older releases (which I agree :-)). Is there still something which blocks us from doing so? You mentioned the cherrypick-robot?

@kargakis

This comment has been minimized.

Copy link
Member

kargakis commented Aug 15, 2018

Nothing blocking, somebody needs to manually do the cherrypick and open a new PR (in the absence of the cherrypick robot).

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Aug 15, 2018

@amwat want to take a look at deploying the cherry pick robot?

mattmb added a commit to Yelp/paasta that referenced this pull request Sep 7, 2018

Make k8s wait-for-deployment work
* generalise checking of marathon status in wait-for-deployment cli to
check "long_running_status" which is either k8s or marathon
* Ensure that app_count in the HTTP status API is an accurate
representation of whether k8s has finished a deployment by counting
pods for a service with unique shas.
* Ensure deployment info for StatefulSet is also accurate. Note that
until kubernetes/kubernetes#62943 is released
the status of a StatefulSet deployment may not be 100% accurate.

mattmb added a commit to Yelp/paasta that referenced this pull request Sep 11, 2018

Make k8s wait-for-deployment work
* generalise checking of marathon status in wait-for-deployment cli to
check "long_running_status" which is either k8s or marathon
* Ensure that app_count in the HTTP status API is an accurate
representation of whether k8s has finished a deployment by counting
pods for a service with unique shas.
* Ensure deployment info for StatefulSet is also accurate. Note that
until kubernetes/kubernetes#62943 is released
the status of a StatefulSet deployment may not be 100% accurate.

mattmb added a commit to Yelp/paasta that referenced this pull request Sep 11, 2018

Make k8s wait-for-deployment work
* generalise checking of marathon status in wait-for-deployment cli to
check "long_running_status" which is either k8s or marathon
* Ensure that app_count in the HTTP status API is an accurate
representation of whether k8s has finished a deployment by counting
pods for a service with unique shas.
* Ensure deployment info for StatefulSet is also accurate. Note that
until kubernetes/kubernetes#62943 is released
the status of a StatefulSet deployment may not be 100% accurate.

k8s-ci-robot added a commit that referenced this pull request Oct 19, 2018

Merge pull request #67570 from sfudeus/automated-cherry-pick-of-#6294…
…3-upstream-release-1.11

Automated cherry pick of #62943: set updated replicas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.