Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
re-enable nodeipam in kube-controller-manager #63049
What this PR does / why we need it:
In v1.10 we made a change (9187b34#diff-f11913dc67d80d36b3d06a93f61c49cf in #57492) where nodeipam would be disabled for any cluster that sets
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
I guess I'm fine for now. However I think we need to get away from conflating meaning on configuration flags. I believe at some point will want to be able to have allocate-node-cidrs set to true and disable this controller on the KCM. Especially if we move forward on component config (kubernetes/enhancements#115).
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing