Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipvs proxy bind externalIP and lb ingress.IP to dummy interface #63066

Merged
merged 1 commit into from Apr 25, 2018

Conversation

@Lion-Wei
Copy link
Contributor

Lion-Wei commented Apr 24, 2018

What this PR does / why we need it:
IPVS proxy bind externalIP and lb ingress.IP to dummy interface.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #59976

Special notes for your reviewer:

Release note:

NONE
@Lion-Wei

This comment has been minimized.

Copy link
Contributor Author

Lion-Wei commented Apr 25, 2018

@uablrek @danderson PTAL.
/assign @m1093782566
I think this is ready for review.

@m1093782566

This comment has been minimized.

Copy link
Member

m1093782566 commented Apr 25, 2018

/approve

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 25, 2018
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 25, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lion-Wei, m1093782566

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Apr 25, 2018

Automatic merge from submit-queue (batch tested with PRs 63129, 63066, 60009, 63136, 63086). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 9a841b3 into kubernetes:master Apr 25, 2018
15 checks passed
15 checks passed
Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation Lion-Wei authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@song-jiang song-jiang mentioned this pull request Dec 5, 2018
0 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.