Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openapi and doc to reflect 202 path in API server delete handler #63418

Merged
merged 2 commits into from Jul 17, 2018

Conversation

Projects
None yet
7 participants
@roycaihw
Copy link
Member

roycaihw commented May 4, 2018

What this PR does / why we need it:
Our API server returns 202 Accepted if a delete operation is asynchronous, but it is not reflected in our openapi spec and documentation. This PR adds 202 path in endpoint installer and updates our openapi spec and docs. The change in openapi spec may affect some clients that depend on the error paths. Python client only depends on response type, which is not changed in this PR. Sending this PR to see if it breaks client-go.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
ref #33196

Special notes for your reviewer:

Release note:

OpenAPI spec and documentation reflect 202 Accepted response path for delete request

@k8s-ci-robot k8s-ci-robot requested review from ncdc , piosz and timothysc May 4, 2018

@roycaihw roycaihw changed the title Update openapi and doc to reflect 202 path in Update openapi and doc to reflect 202 path in API server delete handler May 4, 2018

@roycaihw

This comment has been minimized.

Copy link
Member Author

roycaihw commented May 4, 2018

/sig api-machinery

@roycaihw

This comment has been minimized.

Copy link
Member Author

roycaihw commented May 4, 2018

/test pull-kubernetes-e2e-kops-aws

@ncdc

This comment has been minimized.

Copy link
Member

ncdc commented May 10, 2018

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from ncdc May 10, 2018

@lavalamp

This comment has been minimized.

Copy link
Member

lavalamp commented May 10, 2018

/assign @mbohlool

@mbohlool

This comment has been minimized.

Copy link
Member

mbohlool commented May 22, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 22, 2018

@roycaihw

This comment has been minimized.

Copy link
Member Author

roycaihw commented May 22, 2018

/retest

@roycaihw roycaihw force-pushed the roycaihw:openapi-delete-path branch from f2359e0 to cd18e5e May 24, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 24, 2018

@roycaihw roycaihw force-pushed the roycaihw:openapi-delete-path branch from cd18e5e to 0ff4351 May 24, 2018

@roycaihw

This comment has been minimized.

Copy link
Member Author

roycaihw commented May 24, 2018

/retest

@roycaihw roycaihw force-pushed the roycaihw:openapi-delete-path branch from 0ff4351 to cb2860a May 25, 2018

@roycaihw

This comment has been minimized.

Copy link
Member Author

roycaihw commented May 31, 2018

/retest

@mbohlool

This comment has been minimized.

Copy link
Member

mbohlool commented Jun 1, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 1, 2018

@mbohlool

This comment has been minimized.

Copy link
Member

mbohlool commented Jun 1, 2018

/retest

@roycaihw

This comment has been minimized.

Copy link
Member Author

roycaihw commented Jul 10, 2018

/retest

1 similar comment
@roycaihw

This comment has been minimized.

Copy link
Member Author

roycaihw commented Jul 11, 2018

/retest

roycaihw added some commits May 4, 2018

@roycaihw roycaihw force-pushed the roycaihw:openapi-delete-path branch from cb2860a to 9ad6d72 Jul 11, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 11, 2018

@roycaihw

This comment has been minimized.

Copy link
Member Author

roycaihw commented Jul 12, 2018

Rebase and generate the 202 path for new APIs.

@mbohlool If you could add the LGTM label again.

/assign @liggitt
for approval.

@mbohlool

This comment has been minimized.

Copy link
Member

mbohlool commented Jul 14, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 14, 2018

@roycaihw

This comment has been minimized.

Copy link
Member Author

roycaihw commented Jul 17, 2018

/retest

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jul 17, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mbohlool, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 17, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 17, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit a74df59 into kubernetes:master Jul 17, 2018

16 of 17 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation roycaihw authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@roycaihw roycaihw deleted the roycaihw:openapi-delete-path branch Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.