Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiextensions: promote CustomResourcesSubresources to beta #63598

Merged
merged 2 commits into from
May 19, 2018

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented May 9, 2018

Fixes #62786

This PR promotes the CustomResourcesSubResources feature to beta and makes it enabled by default.

Release note:

Subresources for custom resources is now beta and enabled by default. With this, updates to the `/status` subresource will disallow updates to all fields other than `.status` (not just `.spec` and `.metadata` as before). Also, `required` can be used at the root of the CRD OpenAPI validation schema when the `/status` subresource is enabled.

/assign sttts deads2k
/sig api-machinery
/area custom-resources

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 9, 2018
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/custom-resources cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 9, 2018
@sttts
Copy link
Contributor

sttts commented May 9, 2018

Staging godeps must be updated.

@sttts
Copy link
Contributor

sttts commented May 9, 2018

/assign @liggitt

for approval of api and feature changes.

@nikhita
Copy link
Member Author

nikhita commented May 10, 2018

Staging godeps must be updated.

Done.

@ncdc
Copy link
Member

ncdc commented May 10, 2018

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from ncdc May 10, 2018 14:05
@nikhita
Copy link
Member Author

nikhita commented May 10, 2018

/retest

@lavalamp
Copy link
Member

/assign @mbohlool

@nikhita
Copy link
Member Author

nikhita commented May 11, 2018

/retest

@nikhita
Copy link
Member Author

nikhita commented May 11, 2018

All tests are green.

@sttts
Copy link
Contributor

sttts commented May 11, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2018
@nikhita
Copy link
Member Author

nikhita commented May 15, 2018

@liggitt approved?

@nikhita
Copy link
Member Author

nikhita commented May 15, 2018

/uncc dchen1107

@k8s-ci-robot k8s-ci-robot removed the request for review from dchen1107 May 15, 2018 06:16
@sttts
Copy link
Contributor

sttts commented May 15, 2018

@liggitt ping

@liggitt
Copy link
Member

liggitt commented May 19, 2018

/lgtm
/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, nikhita, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 19, 2018

@nikhita: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce 0e32006 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 63598, 63913, 63459, 63963, 60464). If you want to cherry-pick this change to another branch, please follow the instructions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/custom-resources cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants