Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiextensions: promote CustomResourcesSubresources to beta #63598

Merged
merged 2 commits into from May 19, 2018

Conversation

@nikhita
Copy link
Member

nikhita commented May 9, 2018

Fixes #62786

This PR promotes the CustomResourcesSubResources feature to beta and makes it enabled by default.

Release note:

Subresources for custom resources is now beta and enabled by default. With this, updates to the `/status` subresource will disallow updates to all fields other than `.status` (not just `.spec` and `.metadata` as before). Also, `required` can be used at the root of the CRD OpenAPI validation schema when the `/status` subresource is enabled.

/assign sttts deads2k
/sig api-machinery
/area custom-resources

@sttts

This comment has been minimized.

Copy link
Contributor

sttts commented May 9, 2018

Staging godeps must be updated.

@sttts

This comment has been minimized.

Copy link
Contributor

sttts commented May 9, 2018

/assign @liggitt

for approval of api and feature changes.

nikhita added some commits May 9, 2018

@nikhita nikhita force-pushed the nikhita:subresources-to-beta branch from 8667e4e to 0e32006 May 10, 2018

@nikhita

This comment has been minimized.

Copy link
Member Author

nikhita commented May 10, 2018

Staging godeps must be updated.

Done.

@ncdc

This comment has been minimized.

Copy link
Member

ncdc commented May 10, 2018

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from ncdc May 10, 2018

@nikhita

This comment has been minimized.

Copy link
Member Author

nikhita commented May 10, 2018

/retest

@lavalamp

This comment has been minimized.

Copy link
Member

lavalamp commented May 10, 2018

/assign @mbohlool

@nikhita

This comment has been minimized.

Copy link
Member Author

nikhita commented May 11, 2018

/retest

@nikhita

This comment has been minimized.

Copy link
Member Author

nikhita commented May 11, 2018

All tests are green.

@sttts

This comment has been minimized.

Copy link
Contributor

sttts commented May 11, 2018

/lgtm
/approve

@nikhita

This comment has been minimized.

Copy link
Member Author

nikhita commented May 15, 2018

@liggitt approved?

@nikhita

This comment has been minimized.

Copy link
Member Author

nikhita commented May 15, 2018

/uncc dchen1107

@k8s-ci-robot k8s-ci-robot removed the request for review from dchen1107 May 15, 2018

@sttts

This comment has been minimized.

Copy link
Contributor

sttts commented May 15, 2018

@liggitt ping

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented May 19, 2018

/lgtm
/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 19, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, nikhita, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 19, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 19, 2018

@nikhita: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce 0e32006 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 19, 2018

Automatic merge from submit-queue (batch tested with PRs 63598, 63913, 63459, 63963, 60464). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 4b0b91a into kubernetes:master May 19, 2018

16 of 18 checks passed

pull-kubernetes-e2e-gce Job failed.
Details
Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation nikhita authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@sttts sttts added this to the v1.11 milestone Jun 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.