Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove 20x factor in garbage-collector qps #63657
I was discussing offline with @wojtek-t. And among the two options of:
we agreed that the latter one seems to be less riskier as it's probably better to have the GC slower than to make our API call latencies shoot up.
So from the currently running 100-node presubmit where density test already finished, seems like this fix worked:
It went down all the way from >2s to <15ms :)
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
May 10, 2018
14 of 16 checks passed
referenced this pull request
May 10, 2018
The old dynamic client uses one REST client per group version, not per resource (https://github.com/kubernetes/kubernetes/blob/v1.10.2/staging/src/k8s.io/client-go/dynamic/client_pool.go#L102).
core/v1, apps/v1, extensions/v1beta1, batch/v1 are the group versions that actively use the garbage collector, so 4*5 qps is close enough to restore the old GC performance (@deads2k sorry I didn't realize 20X qps would cause problem when reviewed your PR).