Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually support service `publishNotReadyAddresses` #63742

Merged
merged 1 commit into from May 15, 2018

Conversation

@thockin
Copy link
Member

thockin commented May 11, 2018

This was added and the annotation was deprecated, but it was never
implemented.

xref #63741

Release note:

The annotation `service.alpha.kubernetes.io/tolerate-unready-endpoints` is deprecated.  Users should use Service.spec.publishNotReadyAddresses instead.
@thockin

This comment has been minimized.

Copy link
Member Author

thockin commented May 14, 2018

/retest

Actually support service `publishNotReadyAddresses`
This was added and the annotation was deprecated, but it was never
implemented.

@thockin thockin force-pushed the thockin:kill-tolerate-unready-annotation branch from db306e4 to c038f60 May 14, 2018

@MrHohn

MrHohn approved these changes May 14, 2018

Copy link
Member

MrHohn left a comment

Surprised that this is not implemented..
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 14, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 14, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MrHohn

This comment has been minimized.

Copy link
Member

MrHohn commented May 14, 2018

cc @kow3ns

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 15, 2018

Automatic merge from submit-queue (batch tested with PRs 63792, 63495, 63742, 63332, 63779). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 944e074 into kubernetes:master May 15, 2018

16 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation thockin authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@enisoc

This comment has been minimized.

Copy link
Member

enisoc commented May 24, 2018

Surprised that this is not implemented..

The reason this hadn't been implemented yet was explained in #61056 (comment)

With that said, I talked to @kow3ns after that comment and he seemed willing to consider this type of implementation, at least as an intermediate step.

mikkeloscar added a commit to mikkeloscar/kubernetes that referenced this pull request Sep 14, 2018

Fix Redis StatefulSet e2e test
This fixes the Redis StatefulSet e2e test by adding the missing `publishNotReadyAddresses: true` field, which was accidentially left out in kubernetes#63742.

Without this fix, the redis e2e test will fail because the pod is unable
to lookup the service:

```
2018/09/14 13:57:10 lookup redis on 172.31.9.247:53: no such host
```

Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>

vithati added a commit to vithati/kubernetes that referenced this pull request Oct 25, 2018

Fix Redis StatefulSet e2e test
This fixes the Redis StatefulSet e2e test by adding the missing `publishNotReadyAddresses: true` field, which was accidentially left out in kubernetes#63742.

Without this fix, the redis e2e test will fail because the pod is unable
to lookup the service:

```
2018/09/14 13:57:10 lookup redis on 172.31.9.247:53: no such host
```

Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>

goodluckbot added a commit to goodluckbot/kubernetes that referenced this pull request Nov 11, 2018

Fix Redis StatefulSet e2e test
This fixes the Redis StatefulSet e2e test by adding the missing `publishNotReadyAddresses: true` field, which was accidentially left out in kubernetes#63742.

Without this fix, the redis e2e test will fail because the pod is unable
to lookup the service:

```
2018/09/14 13:57:10 lookup redis on 172.31.9.247:53: no such host
```

Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>

phenixblue added a commit to phenixblue/kubernetes that referenced this pull request Jan 24, 2019

Fix Redis StatefulSet e2e test
This fixes the Redis StatefulSet e2e test by adding the missing `publishNotReadyAddresses: true` field, which was accidentially left out in kubernetes#63742.

Without this fix, the redis e2e test will fail because the pod is unable
to lookup the service:

```
2018/09/14 13:57:10 lookup redis on 172.31.9.247:53: no such host
```

Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>

@alaypatel07 alaypatel07 referenced this pull request Mar 13, 2019

Merged

Add HA etcd sample #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.