Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFS support for default storage #63817

Merged
merged 1 commit into from May 16, 2018

Conversation

Projects
None yet
4 participants
@hyperbolic2346
Copy link
Contributor

hyperbolic2346 commented May 14, 2018

What this PR does / why we need it:
Adds NFS support for kubernetes-worker charm allowing default storage for NFS charms.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Added support for NFS relations on kubernetes-worker charm.
@Cynerva

This comment has been minimized.

Copy link
Contributor

Cynerva commented May 14, 2018

/ok-to-test

@@ -14,6 +14,7 @@ includes:
- 'interface:kube-dns'
- 'interface:kube-control'
- 'interface:aws'
- 'interface:mount'

This comment has been minimized.

@Cynerva

Cynerva May 14, 2018

Contributor

Can you get interface-mount added to https://github.com/juju/layer-index? We shouldn't land this PR until it's in there.

This comment has been minimized.

@hyperbolic2346

hyperbolic2346 May 14, 2018

Author Contributor
spec:
containers:
- name: nfs-client-provisioner
image: quay.io/external_storage/nfs-client-provisioner:latest

This comment has been minimized.

@Cynerva

Cynerva May 14, 2018

Contributor

This is an amd64 image, meaning the NFS relation won't work on arm64, s390x, or others.

Let me think about this some more. I'll come back to this PR tomorrow.

This comment has been minimized.

@hyperbolic2346

hyperbolic2346 May 15, 2018

Author Contributor

Good point. I see an arm version, but nothing for s390x or others..

quay.io/external_storage/nfs-client-provisioner-arm:latest

This comment has been minimized.

@Cynerva

Cynerva May 16, 2018

Contributor

Discussed this offline, we settled on just shipping amd64 support for now.

@Cynerva

This comment has been minimized.

Copy link
Contributor

Cynerva commented May 14, 2018

/assign @Cynerva

@Cynerva

This comment has been minimized.

Copy link
Contributor

Cynerva commented May 16, 2018

/lgtm

Thanks @hyperbolic2346

@k8s-ci-robot k8s-ci-robot added the lgtm label May 16, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynerva, hyperbolic2346

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 16, 2018

Automatic merge from submit-queue (batch tested with PRs 63875, 63817). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 7bafcf4 into kubernetes:master May 16, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation hyperbolic2346 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.