Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore pre-1.10 openstack instance naming behavior #63903

Merged
merged 3 commits into from May 16, 2018

Conversation

@liggitt
Copy link
Member

liggitt commented May 16, 2018

As noted in #61890 (comment) and #62295 (comment), the 1.10 changes to the openstack cloud provider node name computation (in #58502, #61000, and #61890) broke existing deployments that provisioned instances with credentials matching their instance names. It also did not account for version skewed kubelets, which can run 1.8 and 1.9 versions against a 1.10 master, and still register based on instance name.

This PR reverts the incompatible changes to restore pre-1.10 behavior.

Further improvements to handle instances with names that cannot be used as node names are tracked in #62295

/assign @dims
/sig openstack
/kind bug

Restores the pre-1.10 behavior of the openstack cloud provider which uses the instance name as the Kubernetes Node name. This requires instances be named with RFC-1123 compatible names.

liggitt added some commits May 16, 2018

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented May 16, 2018

@dims

This comment has been minimized.

Copy link
Member

dims commented May 16, 2018

/hold

i'd like to check on alternative(s) today

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented May 16, 2018

i'd like to check on alternative(s) today

Do you have specific ideas you can share?

The window for 1.10.3 is rapidly closing (must be merged to release-1.10 by EOD tomorrow). Given the current state, I think we should prioritize fixing the compatibility break in 1.10.x.

Especially given the skewed kubelet requirement, it seems like attempting to support both old and new approaches simultaneously and compatibly will be larger/more complex, and will almost certainly miss 1.10.3.

@dims

This comment has been minimized.

Copy link
Member

dims commented May 16, 2018

@liggitt looking to see if it could be configurable - "name" / "hostname" / "uuid".

@dims

This comment has been minimized.

Copy link
Member

dims commented May 16, 2018

/assign @dixudx

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 16, 2018

[MILESTONENOTIFIER] Milestone Pull Request Needs Approval

@dims @dixudx @liggitt @kubernetes/sig-openstack-misc

Action required: This pull request must have the status/approved-for-milestone label applied by a SIG maintainer. If the label is not applied within 7 days, the pull request will be moved out of the v1.10 milestone.

Pull Request Labels
  • sig/openstack: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help
@dims

This comment has been minimized.

Copy link
Member

dims commented May 16, 2018

/hold cancel

May be it's better to go back to the drawing board than try to rush more changes.

@dims

This comment has been minimized.

Copy link
Member

dims commented May 16, 2018

@FengyunPan2 @dixudx @NickrenREN please take a look.

/approve

@dixudx

This comment has been minimized.

Copy link
Member

dixudx commented May 16, 2018

broke existing deployments that provisioned instances with credentials matching their instance names. It also did not account for version skewed kubelets, which can run 1.8 and 1.9 versions against a 1.10 master, and still register based on instance name.

This is painful when back porting older versions. But we have to go through this.

Seems it's better to roll back to that older flawed version unless we can find a new backwards compatible way.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 16, 2018

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 16, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented May 16, 2018

/retest

@hogepodge

This comment has been minimized.

Copy link
Member

hogepodge commented May 16, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, dixudx, hogepodge, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 16, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 835afe6 into kubernetes:master May 16, 2018

16 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-kubemark-e2e-gce
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@liggitt liggitt deleted the liggitt:openstack-node-name branch May 16, 2018

k8s-github-robot pushed a commit that referenced this pull request May 17, 2018

Kubernetes Submit Queue
Merge pull request #63934 from liggitt/automated-cherry-pick-of-#6390…
…3-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #63903: Revert "Specify DHCP domain for hostname"

Cherry pick of #63903 on release-1.10.

#63903: Revert "Specify DHCP domain for hostname"

rfranzke added a commit to gardener/gardener that referenced this pull request May 29, 2018

Enable OpenStack Shoots for Kubernetes >= 1.10.3
- The behavior prior to 1.10 has been re-introduced. See kubernetes/kubernetes#63903 for details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.