Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Restore pre-1.10 openstack instance naming behavior #63903
As noted in #61890 (comment) and #62295 (comment), the 1.10 changes to the openstack cloud provider node name computation (in #58502, #61000, and #61890) broke existing deployments that provisioned instances with credentials matching their instance names. It also did not account for version skewed kubelets, which can run 1.8 and 1.9 versions against a 1.10 master, and still register based on instance name.
This PR reverts the incompatible changes to restore pre-1.10 behavior.
Further improvements to handle instances with names that cannot be used as node names are tracked in #62295
referenced this pull request
May 16, 2018
May 16, 2018
Do you have specific ideas you can share?
The window for 1.10.3 is rapidly closing (must be merged to release-1.10 by EOD tomorrow). Given the current state, I think we should prioritize fixing the compatibility break in 1.10.x.
Especially given the skewed kubelet requirement, it seems like attempting to support both old and new approaches simultaneously and compatibly will be larger/more complex, and will almost certainly miss 1.10.3.
[MILESTONENOTIFIER] Milestone Pull Request Needs Approval
Action required: This pull request must have the
Pull Request Labels
This is painful when back porting older versions. But we have to go through this.
Seems it's better to roll back to that older flawed version unless we can find a new backwards compatible way.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing