-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore pre-1.10 openstack instance naming behavior #63903
Restore pre-1.10 openstack instance naming behavior #63903
Conversation
cc @kubernetes/sig-openstack-pr-reviews |
/hold i'd like to check on alternative(s) today |
Do you have specific ideas you can share? The window for 1.10.3 is rapidly closing (must be merged to release-1.10 by EOD tomorrow). Given the current state, I think we should prioritize fixing the compatibility break in 1.10.x. Especially given the skewed kubelet requirement, it seems like attempting to support both old and new approaches simultaneously and compatibly will be larger/more complex, and will almost certainly miss 1.10.3. |
@liggitt looking to see if it could be configurable - "name" / "hostname" / "uuid". |
/assign @dixudx |
[MILESTONENOTIFIER] Milestone Pull Request Needs Approval @dims @dixudx @liggitt @kubernetes/sig-openstack-misc Action required: This pull request must have the Pull Request Labels
|
/hold cancel May be it's better to go back to the drawing board than try to rush more changes. |
@FengyunPan2 @dixudx @NickrenREN please take a look. /approve |
This is painful when back porting older versions. But we have to go through this. Seems it's better to roll back to that older flawed version unless we can find a new backwards compatible way. /lgtm |
/test all [submit-queue is verifying that this PR is safe to merge] |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, dixudx, hogepodge, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
- The behavior prior to 1.10 has been re-introduced. See kubernetes/kubernetes#63903 for details.
As noted in #61890 (comment) and #62295 (comment), the 1.10 changes to the openstack cloud provider node name computation (in #58502, #61000, and #61890) broke existing deployments that provisioned instances with credentials matching their instance names. It also did not account for version skewed kubelets, which can run 1.8 and 1.9 versions against a 1.10 master, and still register based on instance name.
This PR reverts the incompatible changes to restore pre-1.10 behavior.
Further improvements to handle instances with names that cannot be used as node names are tracked in #62295
/assign @dims
/sig openstack
/kind bug