Restore pre-1.10 openstack instance naming behavior

[liggitt]

As noted in #61890 (comment) and #62295 (comment), the 1.10 changes to the openstack cloud provider node name computation (in #58502, #61000, and #61890) broke existing deployments that provisioned instances with credentials matching their instance names. It also did not account for version skewed kubelets, which can run 1.8 and 1.9 versions against a 1.10 master, and still register based on instance name.

This PR reverts the incompatible changes to restore pre-1.10 behavior.

Further improvements to handle instances with names that cannot be used as node names are tracked in #62295

/assign @dims
/sig openstack
/kind bug

Restores the pre-1.10 behavior of the openstack cloud provider which uses the instance name as the Kubernetes Node name. This requires instances be named with RFC-1123 compatible names.

[liggitt]

cc @kubernetes/sig-openstack-pr-reviews

[dims]

/hold

i'd like to check on alternative(s) today

[liggitt]

i'd like to check on alternative(s) today

Do you have specific ideas you can share?

The window for 1.10.3 is rapidly closing (must be merged to release-1.10 by EOD tomorrow). Given the current state, I think we should prioritize fixing the compatibility break in 1.10.x.

Especially given the skewed kubelet requirement, it seems like attempting to support both old and new approaches simultaneously and compatibly will be larger/more complex, and will almost certainly miss 1.10.3.

[dims]

@liggitt looking to see if it could be configurable - "name" / "hostname" / "uuid".

[dims]

/assign @dixudx

[k8s-github-robot]

[MILESTONENOTIFIER] Milestone Pull Request Needs Approval

@dims @dixudx @liggitt @kubernetes/sig-openstack-misc

Action required: This pull request must have the status/approved-for-milestone label applied by a SIG maintainer. If the label is not applied within 7 days, the pull request will be moved out of the v1.10 milestone.

Pull Request Labels

• sig/openstack: Pull Request will be escalated to these SIGs if needed.
• priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
• kind/bug: Fixes a bug discovered during the current release.

Help

• Additional instructions
• Commands for setting labels

[dims]

/hold cancel

May be it's better to go back to the drawing board than try to rush more changes.

[dims]

@FengyunPan2 @dixudx @NickrenREN please take a look.

/approve

[dixudx]

broke existing deployments that provisioned instances with credentials matching their instance names. It also did not account for version skewed kubelets, which can run 1.8 and 1.9 versions against a 1.10 master, and still register based on instance name.

This is painful when back porting older versions. But we have to go through this.

Seems it's better to roll back to that older flawed version unless we can find a new backwards compatible way.

/lgtm

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[liggitt]

/retest

[hogepodge]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, dixudx, hogepodge, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cloudprovider/providers/openstack/OWNERS [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-github-robot]

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.