Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to pass extra arguments to etcd. #63961

Merged
merged 1 commit into from May 17, 2018

Conversation

Projects
None yet
4 participants
@mborsz
Copy link
Member

mborsz commented May 17, 2018

What this PR does / why we need it:
It adds a way to pass additional arguments to etcd. They can be used to adjust runtime configuration like heartbeat interval etc.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Add a way to pass extra arguments to etcd.
@mborsz

This comment has been minimized.

Copy link
Member Author

mborsz commented May 17, 2018

/assign @wojtek-t

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented May 17, 2018

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm label May 17, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 17, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@mborsz

This comment has been minimized.

Copy link
Member Author

mborsz commented May 17, 2018

/retest

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 17, 2018

Automatic merge from submit-queue (batch tested with PRs 63749, 63961). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 469532c into kubernetes:master May 17, 2018

6 of 18 checks passed

pull-kubernetes-bazel-test Job failed.
Details
pull-kubernetes-e2e-kops-aws Job failed.
Details
Submit Queue Required Github CI test is not green: pull-kubernetes-bazel-build
Details
pull-kubernetes-bazel-build Job triggered.
Details
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job triggered.
Details
pull-kubernetes-integration Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
pull-kubernetes-node-e2e Job triggered.
Details
pull-kubernetes-verify Job triggered.
Details
cla/linuxfoundation mborsz authorized
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-typecheck Job succeeded.
Details

k8s-github-robot pushed a commit that referenced this pull request May 22, 2018

Kubernetes Submit Queue
Merge pull request #64086 from mborsz/automated-cherry-pick-of-#63961…
…-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #63961: Add a way to pass extra arguments to etcd.

Cherry pick of #63961 on release-1.8.

#63961: Add a way to pass extra arguments to etcd.

k8s-github-robot pushed a commit that referenced this pull request May 24, 2018

Kubernetes Submit Queue
Merge pull request #64084 from mborsz/automated-cherry-pick-of-#63961…
…-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #63961: Add a way to pass extra arguments to etcd.

Cherry pick of #63961 on release-1.10.

#63961: Add a way to pass extra arguments to etcd.

k8s-github-robot pushed a commit that referenced this pull request May 25, 2018

Kubernetes Submit Queue
Merge pull request #64085 from mborsz/automated-cherry-pick-of-#63961…
…-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #63961: Add a way to pass extra arguments to etcd.

Cherry pick of #63961 on release-1.9.

#63961: Add a way to pass extra arguments to etcd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.