Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating ext3/ext4 volume, disable reserved blocks #64102

Merged
merged 1 commit into from May 23, 2018

Conversation

Projects
None yet
6 participants
@atombender
Copy link
Contributor

atombender commented May 21, 2018

What this PR does / why we need it:
When creating ext3/ext4 volume, mkfs defaults to reserving 5% of the volume for the super-user (root). This patch changes the mkfs to pass -m0 to disable this setting.

Rationale: Reserving a percentage of the volume is generally a neither useful nor desirable feature for volumes that aren't used as root file systems for Linux distributions, since the reserved portion becomes unavailable for non-root users. For containers, the general case is to use the entire volume for data, without running as root. The case where one might want reserved blocks enabled is much rarer.

Special notes for your reviewer:
I also added some comments to describe the flags passed to mkfs.

Release note:

Changes ext3/ext4 volume creation to not reserve any portion of the volume for the root user.
@atombender

This comment has been minimized.

Copy link
Contributor Author

atombender commented May 21, 2018

Dang, forgot that the mkfs tests are skipped on macOS. I'm going to push a test also.

@atombender atombender force-pushed the atombender:ext-reserved-blocks branch from 1bc35f7 to 872b05e May 21, 2018

When creating ext3/ext4 volume, pass -m0 to mkfs in order to disable the
super-user-reserved blocks, which otherwise defaults to 5% of the
entire disk.

Rationale: Reserving a percentage of the volume is generally a neither
useful nor desirable feature for volumes that aren't used as root file
systems for Linux distributions, since the reserved portion becomes
unavailable for non-root users. For containers, the general case is to
use the entire volume for data, without running as root. The case where
one might want reserved blocks enabled is much rarer.

@atombender atombender force-pushed the atombender:ext-reserved-blocks branch from 872b05e to 1b3dee9 May 21, 2018

@atombender

This comment has been minimized.

Copy link
Contributor Author

atombender commented May 21, 2018

Force-pushed with test.

@gnufied

This comment has been minimized.

Copy link
Member

gnufied commented May 21, 2018

/ok-to-test

@atombender

This comment has been minimized.

Copy link
Contributor Author

atombender commented May 21, 2018

/test pull-kubernetes-e2e-gce

@andyzhangx

This comment has been minimized.

Copy link
Member

andyzhangx commented May 22, 2018

@atombender could you change release-note to Changes ext3/ext4 volume creation to not reserve any portion of the volume for the root user, original one contains two many words.

@andyzhangx
Copy link
Member

andyzhangx left a comment

/lgtm

@andyzhangx

This comment has been minimized.

Copy link
Member

andyzhangx commented May 22, 2018

/assign @jsafrane

@atombender

This comment has been minimized.

Copy link
Contributor Author

atombender commented May 22, 2018

@andyzhangx Done. Though as an occasional reader of release notes, I'd have wanted more context and explanation.

@andyzhangx

This comment has been minimized.

Copy link
Member

andyzhangx commented May 22, 2018

@atombender more explanation details could be in PR other than in release-note

@jsafrane

This comment has been minimized.

Copy link
Member

jsafrane commented May 23, 2018

/approve no-issue

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, atombender, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 23, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 23, 2018

Automatic merge from submit-queue (batch tested with PRs 64102, 63303, 64150, 63841). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 60b6263 into kubernetes:master May 23, 2018

13 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation atombender authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.