Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
changed the default value for allow-privileged for the kubelet (kuber… #64104
What this PR does / why we need it:
This PR modifies the default value for the kubernetes-worker: it sets the allow-privileged kubelet value to true, based on this issue:juju-solutions/bundle-canonical-kubernetes#579.
The original PR was here: #63442 which included this change for the k8s 1.10 release. This PR incorporates this fix into the Canonical distribution of Kubernetes.
Which issue(s) this PR fixes (optional, in
This change fixes two issues:
Special notes for your reviewer:
Waiting review from Canonical Kubernetes charm tea.
referenced this pull request
May 21, 2018
@CalvinHartwell could you add the quotes back in? It's possible that Juju and the kubernetes-worker charm are able to handle this gracefully, but I'd rather not rely on that.
@Cynerva apologies, accidentally a merged an old branch into the mix. I've now fixed that and appended some context to the readme section. More importantly I've also adjusted the same value for the kubernetes-master as this is also causing an issue for workloads.
Looking good? Should be fixed.
Jun 1, 2018
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing