Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check SessionAffinity for Azure load balancer #64180

Merged
merged 3 commits into from May 24, 2018

Conversation

@feiskyer
Copy link
Member

feiskyer commented May 23, 2018

What this PR does / why we need it:

Currently azure load balance rule comparing is based on name which does not have affinity information. So during updating, the loadDistribution property is not updated.

This PR fixes this and adds some verbose logs for better understanding what's happening.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #63908

Special notes for your reviewer:

Cherry pick to 1.10.

Release note:

Fix SessionAffinity not updated issue for Azure load balancer
@feiskyer

This comment has been minimized.

Copy link
Member Author

feiskyer commented May 23, 2018

@k8s-ci-robot k8s-ci-robot requested a review from karataliu May 23, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 23, 2018

@feiskyer: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.10, v1.11, v1.12, v1.13, v1.4, v1.5, v1.6, v1.7, v1.8, v1.9]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feiskyer

This comment has been minimized.

Copy link
Member Author

feiskyer commented May 23, 2018

/milestone v1.11

@feiskyer

This comment has been minimized.

Copy link
Member Author

feiskyer commented May 23, 2018

/sig azure

@feiskyer

This comment has been minimized.

Copy link
Member Author

feiskyer commented May 23, 2018

/status approved-for-milestone

@@ -1255,7 +1259,7 @@ func findProbe(probes []network.Probe, probe network.Probe) bool {

func findRule(rules []network.LoadBalancingRule, rule network.LoadBalancingRule) bool {
for _, existingRule := range rules {
if strings.EqualFold(*existingRule.Name, *rule.Name) {
if strings.EqualFold(*existingRule.Name, *rule.Name) && reflect.DeepEqual(existingRule.LoadBalancingRulePropertiesFormat, rule.LoadBalancingRulePropertiesFormat) {

This comment has been minimized.

@karataliu

karataliu May 23, 2018

Contributor

If rule name equals, but not deep equal, we should replace the current rule. With this logic, it will add a new one, needs update?

This comment has been minimized.

@feiskyer

feiskyer May 23, 2018

Author Member

it actually replace the rule in such case by removing old one from list and append a new to the list.

@feiskyer feiskyer force-pushed the feiskyer:verbose branch from 464a3e8 to a50ac29 May 24, 2018

@feiskyer

This comment has been minimized.

Copy link
Member Author

feiskyer commented May 24, 2018

@karataliu Added equalLoadBalancingRulePropertiesFormat for only checking used fields. PTAL

@karataliu

This comment has been minimized.

Copy link
Contributor

karataliu commented May 24, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 24, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, karataliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 24, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@feiskyer @karataliu

Pull Request Labels
  • sig/azure: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help
@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 24, 2018

Automatic merge from submit-queue (batch tested with PRs 63434, 64172, 63975, 64180, 63755). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 2feb093 into kubernetes:master May 24, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation feiskyer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@feiskyer feiskyer deleted the feiskyer:verbose branch May 24, 2018

k8s-github-robot pushed a commit that referenced this pull request May 28, 2018

Kubernetes Submit Queue
Merge pull request #64297 from feiskyer/automated-cherry-pick-of-#641…
…80-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #64180:  Check SessionAffinity for Azure load balancer

Cherry pick of #64180 on release-1.10.

#64180: Check SessionAffinity for Azure load balancer

@feiskyer feiskyer restored the feiskyer:verbose branch Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.