Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
kubeadm: Add a 'kubeadm config migrate' command #64232
What this PR does / why we need it:
This is an UX improvement so users may easier "upgrade" their configuration files from the an old version (e.g.
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
I think this is good to have, but I strongly agree with what @liztio suggested. This should be the default behavior in upgrade.
I can see migration behavior as being a "phase" but if we're trying to not lump everything under phases, config is the right place for it.
I see this as the first step to making the config migration automatically happen in the upgrade path while also exposing just this behavior under config for cases where a user wants to see what the new config would look like or maybe run upgrades manually.
i'm ok with a new sub-command that has a specific use.
migrate implies a big action. relocating to something completely different (e.g. birds moving south).
if the command will have future implications that allow it to convert a certain config to any given config version it should be called
it's ok, but it needs documentation outside of cobra and is kind of bound to Unix, because if kubeadm ever supports native Win32 one would need
if this command goes under
my vote for a long term flexible command would be:
also one thing that the command has to do is to create backups and write about that to stdout.
3 similar comments
[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process
Pull Request Labels
[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
The full list of commands accepted by this bot can be found here.
The pull request process is described here