Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the CoreDNS version and manifest #64258

Merged
merged 1 commit into from May 29, 2018

Conversation

@rajansandeep
Copy link
Member

rajansandeep commented May 24, 2018

What this PR does / why we need it:
Bumps CoreDNS to 1.1.3 and updates manifest

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

CoreDNS is now v1.1.3
@rajansandeep

This comment has been minimized.

Copy link
Member Author

rajansandeep commented May 24, 2018

/cc @MrHohn
/cc @luxas

@k8s-ci-robot k8s-ci-robot requested review from luxas and MrHohn May 24, 2018

@rajansandeep rajansandeep force-pushed the rajansandeep:bumpmanifest branch from 4caced3 to 8d8b475 May 24, 2018

update manifest
fix test
@MrHohn

MrHohn approved these changes May 24, 2018

Copy link
Member

MrHohn left a comment

/lgtm

@rajansandeep

This comment has been minimized.

Copy link
Member Author

rajansandeep commented May 25, 2018

/assign @fabriziopandini
/retest
@luxas Want to make sure this gets in before code slush! Thanks!

@luxas

luxas approved these changes May 29, 2018

Copy link
Member

luxas left a comment

/lgtm
/approve

Just one small question, but I guess you want all v1.10.x and v1.11.x versions to use 1.1.3

// v1.9.0+ uses kube-dns 1.14.10
// v1.9.0+ uses CoreDNS 1.0.6 if feature gate "CoreDNS" is enabled.
// v1.9.0+ uses kube-dns 1.14.10, if feature gate "CoreDNS" is disabled.
// v1.9.0+ uses CoreDNS 1.1.3.

This comment has been minimized.

@luxas

luxas May 29, 2018

Member

All kubernetes versions should use 1.1.3 you mean here, right?

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luxas, MrHohn, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@luxas

This comment has been minimized.

Copy link
Member

luxas commented May 29, 2018

/retest

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented May 29, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 29, 2018

Automatic merge from submit-queue (batch tested with PRs 64258, 63068). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit af45e9c into kubernetes:master May 29, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation rajansandeep authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.