Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: rename the `kube-dns` phases addon #64274

Merged
merged 1 commit into from May 29, 2018

Conversation

@neolit123
Copy link
Member

neolit123 commented May 24, 2018

What this PR does / why we need it:
The command kubeadm alpha phases addon has a property
called kube-dns which would install kube-dns, pre 1.11.

In the case of 1.11 this property will install CoreDNS,
because the property is also bound to the CoreDNS feature gate,
which is now true by default.

Fix that by renaming the property to coredns, updating the Cobra
info and also updating the unit tests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes kubernetes/kubeadm#856

Special notes for your reviewer:
Please verify if we are OK with the "hard rename".

Release note:

kubeadm: rename the addon parameter `kube-dns` to `coredns` for `kubeadm alpha phases addons` as CoreDNS is now the default DNS server in 1.11.

@kubernetes/sig-cluster-lifecycle-pr-reviews
/area kubeadm

@neolit123

This comment has been minimized.

Copy link
Member Author

neolit123 commented May 24, 2018

/kind bug
/area ux

@neolit123 neolit123 force-pushed the neolit123:kubeadm-alpha-phase-addon branch from 0f68acb to 336184c May 24, 2018

@neolit123 neolit123 force-pushed the neolit123:kubeadm-alpha-phase-addon branch from 336184c to 9c9a2fe May 24, 2018

@neolit123

This comment has been minimized.

Copy link
Member Author

neolit123 commented May 24, 2018

FYI @timothysc mentioned this on slack:

Just keep in mind that in 1.12 we are planning to eliminate phases in favor for the sub-commands like init

@neolit123

This comment has been minimized.

Copy link
Member Author

neolit123 commented May 24, 2018

/test pull-kubernetes-integration

kubeadm: rename the `kube-dns` phases addon
The command `kubeadm alpha phases addon` has a property
called `kube-dns` which would install kube-dns, pre 1.11.

In the case of 1.11 this property will install CoreDNS,
because the property is also bound to the `CoreDNS` feature gate,
which is now `true` by default.

Fix that by renaming the property to `coredns`, updating the Cobra
info and also updating the unit tests.

@neolit123 neolit123 force-pushed the neolit123:kubeadm-alpha-phase-addon branch from 9c9a2fe to ebc254c May 24, 2018

@timothysc
Copy link
Member

timothysc left a comment

/approve

I'm ok with this change, I'll let @detiber have final lgtm.

@timothysc timothysc added the approved label May 25, 2018

@timothysc

This comment has been minimized.

Copy link
Member

timothysc commented May 25, 2018

/assign @detiber

@tengqm

This comment has been minimized.

Copy link
Contributor

tengqm commented May 27, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 27, 2018

@tengqm: changing LGTM is restricted to assignees, and only kubernetes org members may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luxas

luxas approved these changes May 28, 2018

Copy link
Member

luxas left a comment

/lgtm
Thanks @neolit123!

@k8s-ci-robot k8s-ci-robot added the lgtm label May 28, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 28, 2018

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: luxas, neolit123, tengqm, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 29, 2018

Automatic merge from submit-queue (batch tested with PRs 64308, 64367, 64165, 64274). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 046619f into kubernetes:master May 29, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation neolit123 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.