Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that only IPs are used as node addresses in OpenStack LBs #64318

Merged
merged 1 commit into from May 30, 2018

Conversation

@gonzolino
Copy link
Member

gonzolino commented May 25, 2018

What this PR does / why we need it:
ATM, when no InternalIP can be found for a node, the openstack cloud provider tries to create a LB with whatever is the first address it can find for the node. This could also be the hostname or a dns name.
However, LBaaS will reject anything that is not an IP address for pool members. Therefore a meaningful error should be returned instead of just returning the first address of the node, even if it is clear that this will lead to an error in LBaaS.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #64317

Special notes for your reviewer:

Release note:

Provide a meaningful error message in openstack cloud provider when no valid IP address can be found for a node
@dims

This comment has been minimized.

Copy link
Member

dims commented May 26, 2018

/test pull-kubernetes-kubemark-e2e-gce-big

@dims

This comment has been minimized.

Copy link
Member

dims commented May 26, 2018

/assign @FengyunPan2

@dims

dims approved these changes May 26, 2018

@anguslees

This comment has been minimized.

Copy link
Member

anguslees commented May 30, 2018

/lgtm

@FengyunPan2
Copy link
Contributor

FengyunPan2 left a comment

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 30, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anguslees, FengyunPan2, gonzolino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims

This comment has been minimized.

Copy link
Member

dims commented May 30, 2018

/milestone v1.11

@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone May 30, 2018

@dims

This comment has been minimized.

Copy link
Member

dims commented May 30, 2018

/kind bug
/priority important-soon

@dims

This comment has been minimized.

Copy link
Member

dims commented May 30, 2018

/sig openstack

@dims

This comment has been minimized.

Copy link
Member

dims commented May 30, 2018

/status approved-for-milestone

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 30, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@FengyunPan2 @anguslees @gonzolino

Pull Request Labels
  • sig/openstack: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help
@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 30, 2018

Automatic merge from submit-queue (batch tested with PRs 64318, 64269, 64438, 64516, 64311). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 5aa5134 into kubernetes:master May 30, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation gonzolino authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.