New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccm: recognize InstanceNotFound from InstanceID #64368
ccm: recognize InstanceNotFound from InstanceID #64368
Conversation
Otherwise we won't actually delete Nodes in this code path.
This is the ccm case (less critical) of #64367 |
/retest |
/test pull-kubernetes-e2e-kops-aws /status approved-for-milestone |
/assign @luxas |
[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process Pull Request Labels
|
/approve thanks @justinsb! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
Otherwise we won't actually delete Nodes in this code path.