Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print nodes for those metrics is somehow unreachable #64389

Merged
merged 2 commits into from Jun 20, 2018

Conversation

Projects
None yet
6 participants
@yue9944882
Copy link
Member

yue9944882 commented May 28, 2018

What this PR does / why we need it:

When we use kubectl top nodes, some nodes will be ignored when their metrics cannot be fetched from metrics serve. It might be misleading for users.

This PR helps print the missing nodes like:

NAME                CPU(cores)   CPU%      MEMORY(bytes)   MEMORY%  
missing-nodes       -            -         -               -

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #63986

Special notes for your reviewer:

Release note:

Fixes missing nodes lines when kubectl top nodes
@yue9944882

This comment has been minimized.

Copy link
Member Author

yue9944882 commented May 28, 2018

/kind bug
/sig cli

@adohe

This comment has been minimized.

Copy link
Member

adohe commented May 29, 2018

overall LGTM. I am not quite sure whether we should use - or other more meaningful words here, could refer other kubectl code.

@cgthayer

This comment has been minimized.

Copy link

cgthayer commented May 30, 2018

Looks good to me :-D thanks

@yue9944882

This comment has been minimized.

Copy link
Member Author

yue9944882 commented May 30, 2018

@adohe Thanks.

Seems like there's no such a centric definition as -. A similar usage of <unknown> is found in name printer which could be considered as an example for this. Also <none> is previously used but <unknown> should be better for describing metrics status.


Note that <unknown> is hardcoded across the project (both in client and server) without a centric definition. As of now, I think we could just print it hardcodedly like previous implementation before someone come up with a PR solving this mess. And such a PR should make some changes to "server-side print" together.

@adohe

This comment has been minimized.

Copy link
Member

adohe commented Jun 6, 2018

cool~ let's just keep using <unknown> here.

@adohe

This comment has been minimized.

Copy link
Member

adohe commented Jun 6, 2018

/assign @adohe

@adohe

This comment has been minimized.

Copy link
Member

adohe commented Jun 6, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 6, 2018

@adohe

This comment has been minimized.

Copy link
Member

adohe commented Jun 6, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jun 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adohe, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adohe

adohe approved these changes Jun 6, 2018

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jun 6, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

3 similar comments
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jun 11, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jun 16, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jun 20, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jun 20, 2018

Automatic merge from submit-queue (batch tested with PRs 64882, 64692, 64389, 60626, 64840). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 8a1e830 into kubernetes:master Jun 20, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation yue9944882 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.