Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AWS EBS volumes to be attached as ReadOnly. #64403

Merged
merged 1 commit into from May 31, 2018

Conversation

@jsafrane
Copy link
Member

jsafrane commented May 28, 2018

Which issue(s) this PR fixes
Fixes #64402

Special notes for your reviewer:
This follows logic e.g. in Cinder volume plugin.

Release note:

AWS EBS volumes can be now used as ReadOnly in pods.

/sig storage
/sig aws

@gnufied

This comment has been minimized.

Copy link
Member

gnufied commented May 29, 2018

/assign

@jsafrane

This comment has been minimized.

Copy link
Member Author

jsafrane commented May 29, 2018

/retest

@gnufied

This comment has been minimized.

Copy link
Member

gnufied commented May 29, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 29, 2018

@jsafrane

This comment has been minimized.

Copy link
Member Author

jsafrane commented May 29, 2018

/assign @deads2k @derekwaynecarr
for approval, it's one-line change in an admission test

@deads2k

This comment has been minimized.

Copy link
Contributor

deads2k commented May 29, 2018

/approve

for the admission bits

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented May 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, gnufied, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented May 30, 2018

/milestone v1.11
/status approved-for-milestone

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 30, 2018

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@deads2k @derekwaynecarr @gnufied @jsafrane

Action required: This pull request requires label changes. If the required changes are not made within 3 days, the pull request will be moved out of the v1.11 milestone.

kind: Must specify exactly one of kind/bug, kind/cleanup or kind/feature.
priority: Must specify exactly one of priority/critical-urgent, priority/important-longterm or priority/important-soon.

Help
@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented May 31, 2018

Automatic merge from submit-queue (batch tested with PRs 57082, 64325, 64016, 64443, 64403). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit a1c8d3f into kubernetes:master May 31, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation jsafrane authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.