Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add ContainersReady condition into Pod Status #64646
dixudx left a comment
Mostly lgtm. Some nits.
@freehan: GitHub didn't allow me to assign the following users: for, approval.
Note that only kubernetes members and repo collaborators can be assigned.
Hey folks, from the comments, it sounds like this is desired for 1.11, but it's not labeled correctly for that to happen, and there are additional labels needed if it doesn't merge today before the beginning of code freeze. Please ensure the labels for the milestone and urgency are set correctly.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process
Pull Request Labels
Jun 6, 2018
10 of 18 checks passed
@freehan: The following test failed, say
referenced this pull request
Jun 7, 2018
Hello there! @freehan I'm Zach Arnold working on Docs for the 1.11 release. This PR was identified as one needing some documentation in the https://github.com/kubernetes/website repo around your contributions (thanks by the way!) When you have some time, could you please modify/add/remove the relevant content that needs changing in our documentation repo? Thanks! Please let me or my colleague Misty know (@zparnold/@Misty on K8s Slack) if you need any assistance with the documentation.