Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: kubelet: remote: increase grpc client default size to 16MiB #64672

Merged
merged 1 commit into from Jun 20, 2018

Conversation

Projects
None yet
6 participants
@mcluseau
Copy link
Contributor

mcluseau commented Jun 4, 2018

What this PR does / why we need it:

Increase the gRPC max message size to 16MB in the remote container runtime. I've seen sizes over 8MB in clusters with big (256GB RAM) nodes.

Release note:

Increase the gRPC max message size to 16MB in the remote container runtime.
@mcluseau

This comment has been minimized.

Copy link
Contributor Author

mcluseau commented Jun 4, 2018

/assign @feiskyer

@resouer

This comment has been minimized.

Copy link
Member

resouer commented Jun 4, 2018

/ok-to-test

@resouer

This comment has been minimized.

Copy link
Member

resouer commented Jun 4, 2018

@mcluseau btw, what runtime you are using and see this issue?

@mcluseau

This comment has been minimized.

Copy link
Contributor Author

mcluseau commented Jun 4, 2018

@resouer containerd github.com/containerd/containerd v1.1.0 209a7fc3e4a32ef71a8c7b50c68fc8398415badf

Also, Kubelet is v1.10.4-beta.0.26+257eee17ed0b4c-dirty (branch release-1.10 + my patch applied)

@feiskyer
Copy link
Member

feiskyer left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 4, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jun 4, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, mcluseau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jun 8, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jun 8, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@mcluseau

This comment has been minimized.

Copy link
Contributor Author

mcluseau commented Jun 13, 2018

/retest

k8s-github-robot pushed a commit that referenced this pull request Jun 13, 2018

Kubernetes Submit Queue
Merge pull request #64804 from mcluseau/automated-cherry-pick-of-#63977-
#64672-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #63977: pkg: kubelet: remote: increase grpc client default size #64672: pkg: kubelet: remote: increase grpc client default size to

Cherry pick of #63977 #64672 on release-1.10.

#63977: pkg: kubelet: remote: increase grpc client default size
#64672: pkg: kubelet: remote: increase grpc client default size to

```release-note
CRI: increase grpc client default size to 16MB
```
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jun 18, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jun 20, 2018

Automatic merge from submit-queue (batch tested with PRs 65032, 63471, 64104, 64672, 64427). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit a622f14 into kubernetes:master Jun 20, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation mcluseau authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.