Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable etcdv3 client prometheus metics #64741

Merged
merged 1 commit into from Jul 2, 2018

Conversation

Projects
None yet
10 participants
@wgliang
Copy link
Member

wgliang commented Jun 5, 2018

What this PR does / why we need it:

Provide a way to enable etcdv3 client prometheus metics

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #64740

Special notes for your reviewer:

Release note:

Enable etcdv3 client prometheus metics

@k8s-ci-robot k8s-ci-robot requested review from timothysc and wojtek-t Jun 5, 2018

@wgliang wgliang changed the title enable etcdv3 client prometheus metics [WIP]enable etcdv3 client prometheus metics Jun 5, 2018

@wgliang wgliang changed the title [WIP]enable etcdv3 client prometheus metics enable etcdv3 client prometheus metics Jun 5, 2018

@wgliang wgliang force-pushed the wgliang:master.etcd-prometheus-metics branch from 48c2a28 to e4a63ed Jun 5, 2018

@hzxuzhonghu

This comment has been minimized.

Copy link
Member

hzxuzhonghu commented Jun 5, 2018

Does this influence performance? maybe better have a control flag to enable/disable it.

@wgliang

This comment has been minimized.

Copy link
Member Author

wgliang commented Jun 5, 2018

/test pull-kubernetes-verify

@wgliang wgliang force-pushed the wgliang:master.etcd-prometheus-metics branch 2 times, most recently from 5d14a37 to 1760fb7 Jun 5, 2018

@wgliang wgliang force-pushed the wgliang:master.etcd-prometheus-metics branch 3 times, most recently from a71450c to 47bc1d4 Jun 24, 2018

@@ -36,6 +36,8 @@ go_library(
"//vendor/github.com/coreos/etcd/client:go_default_library",
"//vendor/github.com/coreos/etcd/clientv3:go_default_library",
"//vendor/github.com/coreos/etcd/pkg/transport:go_default_library",
"//vendor/github.com/grpc-ecosystem/go-grpc-prometheus:go_default_library",

This comment has been minimized.

@ixdy

ixdy Jun 25, 2018

Member

To resolve this merge conflict, you should be able to just revert this file (staging/src/k8s.io/apiserver/pkg/storage/storagebackend/factory/BUILD) back to the upstream version, then re-run hack/update-bazel.sh, which should re-add these lines.

Trying to resolve the conflict manually is doable but painful, since so many (but not all) of these //vendor/k8s.io dependencies turned into //staging/src/k8s.io.

@timothysc

This comment has been minimized.

Copy link
Member

timothysc commented Jun 25, 2018

/assign @jpbetz
/unassign @timothysc

@timothysc timothysc removed their request for review Jun 25, 2018

@wgliang wgliang force-pushed the wgliang:master.etcd-prometheus-metics branch from 47bc1d4 to eac15e7 Jun 25, 2018

@wgliang wgliang force-pushed the wgliang:master.etcd-prometheus-metics branch from eac15e7 to 1ee752a Jun 25, 2018

@wgliang wgliang force-pushed the wgliang:master.etcd-prometheus-metics branch from 1ee752a to 956e3f9 Jun 25, 2018

@wgliang wgliang force-pushed the wgliang:master.etcd-prometheus-metics branch from 956e3f9 to 855255b Jun 25, 2018

@wgliang

This comment has been minimized.

Copy link
Member Author

wgliang commented Jun 26, 2018

/retest

@wgliang wgliang force-pushed the wgliang:master.etcd-prometheus-metics branch from 855255b to 0d6c516 Jun 26, 2018

@jpbetz

This comment has been minimized.

Copy link
Contributor

jpbetz commented Jun 26, 2018

Thanks for the PR @wgliang! We already use https://github.com/grpc-ecosystem/go-grpc-prometheus in the etcd server for prometheus metrics so I'm comfortable with using the library.

Just need to sort out the merge conflicts.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 26, 2018

@wgliang

This comment has been minimized.

Copy link
Member Author

wgliang commented Jun 27, 2018

/ping @sttts @lavalamp @cblecker
for approve

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jun 27, 2018

/approve
for Godeps

@sttts

This comment has been minimized.

Copy link
Contributor

sttts commented Jul 2, 2018

/approve

@sttts

This comment has been minimized.

Copy link
Contributor

sttts commented Jul 2, 2018

/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 2, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, jpbetz, sttts, wgliang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wgliang

This comment has been minimized.

Copy link
Member Author

wgliang commented Jul 2, 2018

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 2, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 2, 2018

@wgliang: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-bazel-test 0d6c516 link /test pull-kubernetes-bazel-test
pull-kubernetes-e2e-gce 0d6c516 link /test pull-kubernetes-e2e-gce
pull-kubernetes-e2e-gce-device-plugin-gpu 0d6c516 link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 2, 2018

Automatic merge from submit-queue (batch tested with PRs 64741, 65484). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 1570d38 into kubernetes:master Jul 2, 2018

12 of 17 checks passed

pull-kubernetes-bazel-test Job failed.
Details
pull-kubernetes-e2e-gce Job failed.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job failed.
Details
Submit Queue Required Github CI test is not green: pull-kubernetes-bazel-test
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation wgliang authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@marpaia

This comment has been minimized.

Copy link
Member

marpaia commented Jul 2, 2018

/sig instrumentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.