Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of prometheus-to-sd #64964

Merged
merged 1 commit into from Jun 23, 2018

Conversation

Projects
None yet
7 participants
@loburm
Copy link
Contributor

loburm commented Jun 11, 2018

Bump version of prometheus-to-sd to 0.2.6 to decrease log noise and include latest security patches.
@mbohlool

This comment has been minimized.

Copy link
Member

mbohlool commented Jun 14, 2018

Is less log the only change in the new version? Would be useful if you provide a link to the component's release notes.

@loburm

This comment has been minimized.

Copy link
Contributor Author

loburm commented Jun 18, 2018

@mbohlool it has also some other improvements (translation logic, additional metrics etc), but from user perspective log noise and security patch (I have updated release notes) is the most important.

@piosz

This comment has been minimized.

Copy link
Member

piosz commented Jun 22, 2018

/lgtm
/approve no-issue

@wasylkowski-a

This comment has been minimized.

Copy link

wasylkowski-a commented Jun 22, 2018

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Jun 22, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jun 22, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: loburm, piosz, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jun 23, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jun 23, 2018

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 7baaa33 into kubernetes:release-1.9 Jun 23, 2018

17 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation loburm authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Skipped
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.