Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix kubeadm taints to not override existing node taints #65068
What this PR does / why we need it:
An example of this is that the
referenced this pull request
Jun 13, 2018
The test that failed is
This test is actually asserting that the previous behavior is the correct behavior and goes against what the logic in this PR is. Should I remove the test or does the logic of this change need to be discussed more? I think the test should be removed as I would not expect that taints are removed because they aren't specified in the config file.
@ashleyschuett thanks for your PR!
Ps. It would be great to have specific test cases for the new "merge" behaviour
The test/behaviour came in #55479 where I said in the PR intro:
Which if I understand correctly is exactly the issue here? I have no strong feelings for either behaviour and I don't recall any of the reviewers questioning the above or the behaviour (which makes me suspect they had no particular opinion also rather than explicitly agreed with it doing it that way).
So long as the
Jun 14, 2018
[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process
Pull Request Labels
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing