New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial node performance testing framework. #65250

Merged
merged 1 commit into from Sep 8, 2018

Conversation

@balajismaniam
Member

balajismaniam commented Jun 19, 2018

This PR adds a framework for node performance testing.
Partially fixes: #65249.
Use the following command to run this test:

make test-e2e-node FOCUS="Node Performance Testing" SKIP="" PARALLELISM=1

It has been tested in the following environment:

  • n1-standard-16
  • Ubuntu 16.04
  • docker 17.03.2

Note to reviewers:
This PR won't pass node e2e since the docker images in #65251 are required for this to function. The node e2e will fail when trying to pull the required images for testing.

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Jun 19, 2018

Contributor

@balajismaniam: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

k8s-ci-robot commented Jun 19, 2018

@balajismaniam: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@balajismaniam

This comment has been minimized.

Show comment
Hide comment
@balajismaniam
Member

balajismaniam commented Jun 19, 2018

@ConnorDoyle

This comment has been minimized.

Show comment
Hide comment
@ConnorDoyle

ConnorDoyle Jun 20, 2018

Member

/assign

Member

ConnorDoyle commented Jun 20, 2018

/assign

@vikaschoudhary16

This comment has been minimized.

Show comment
Hide comment
@vikaschoudhary16
Member

vikaschoudhary16 commented Jun 20, 2018

/cc

@k8s-ci-robot k8s-ci-robot requested a review from vikaschoudhary16 Jun 20, 2018

@balajismaniam balajismaniam changed the title from [WIP] Initial node performance testing framework. to Initial node performance testing framework. Jun 29, 2018

@ConnorDoyle

This comment has been minimized.

Show comment
Hide comment
@ConnorDoyle
Member

ConnorDoyle commented Jul 30, 2018

xref: #66075

@RenaudWasTaken

/lgtm

Big fan of this very clean model!

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 29, 2018

@balajismaniam

This comment has been minimized.

Show comment
Hide comment
@balajismaniam

balajismaniam Aug 30, 2018

Member

Thanks for the review @RenaudWasTaken. We will have to wait for #65251 before merging this PR.

/hold
/release-note-none
/milestone v1.12

Member

balajismaniam commented Aug 30, 2018

Thanks for the review @RenaudWasTaken. We will have to wait for #65251 before merging this PR.

/hold
/release-note-none
/milestone v1.12

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 30, 2018

Contributor

@balajismaniam: You must be a member of the kubernetes/kubernetes-milestone-maintainers github team to set the milestone.

In response to this:

Thanks for the review @RenaudWasTaken. We will have to wait for #65251 before merging this PR.

/hold
/release-note-none
/milestone v1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

k8s-ci-robot commented Aug 30, 2018

@balajismaniam: You must be a member of the kubernetes/kubernetes-milestone-maintainers github team to set the milestone.

In response to this:

Thanks for the review @RenaudWasTaken. We will have to wait for #65251 before merging this PR.

/hold
/release-note-none
/milestone v1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Aug 30, 2018

Member

/test pull-kubernetes-node-e2e

Member

dims commented Aug 30, 2018

/test pull-kubernetes-node-e2e

@balajismaniam

This comment has been minimized.

Show comment
Hide comment
@balajismaniam

balajismaniam Aug 30, 2018

Member

@dims pull-kubernetes-node-e2e will fail for this PR because it is trying to pull images from #65251. Those docker images are used as workloads for node performance testing. The gate will pass after we build and push those images.

Member

balajismaniam commented Aug 30, 2018

@dims pull-kubernetes-node-e2e will fail for this PR because it is trying to pull images from #65251. Those docker images are used as workloads for node performance testing. The gate will pass after we build and push those images.

@balajismaniam

This comment has been minimized.

Show comment
Hide comment
@balajismaniam

balajismaniam Aug 30, 2018

Member

Per #65251 (comment), the node e2es should pass now.

/retest

Member

balajismaniam commented Aug 30, 2018

Per #65251 (comment), the node e2es should pass now.

/retest

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Aug 30, 2018

Member

@balajismaniam yes, i requested @cjwagner to build the images :)

Member

dims commented Aug 30, 2018

@balajismaniam yes, i requested @cjwagner to build the images :)

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Aug 30, 2018

Member

/test pull-kubernetes-node-e2e

Member

dims commented Aug 30, 2018

/test pull-kubernetes-node-e2e

@ConnorDoyle

This comment has been minimized.

Show comment
Hide comment
@ConnorDoyle

ConnorDoyle Aug 31, 2018

Member

/retest

Member

ConnorDoyle commented Aug 31, 2018

/retest

@ConnorDoyle

This comment has been minimized.

Show comment
Hide comment
@ConnorDoyle

ConnorDoyle Aug 31, 2018

Member

/milestone v1.12

Member

ConnorDoyle commented Aug 31, 2018

/milestone v1.12

@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Aug 31, 2018

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Aug 31, 2018

Member

@balajismaniam if you rebase this to master you can see why node-e2e is failing. please fix.

[dims@dims-mac 09:27] ~/go/src/k8s.io/kubernetes ⟩ go test -v ./test/e2e_node/
# k8s.io/kubernetes/test/e2e_node
test/e2e_node/node_perf_test.go:25:2: cannot find package "k8s.io/kubernetes/pkg/kubelet/apis/kubeletconfig" in any of:
	/Users/dims/go/src/k8s.io/kubernetes/vendor/k8s.io/kubernetes/pkg/kubelet/apis/kubeletconfig (vendor tree)
	/usr/local/Cellar/go/1.10.2/libexec/src/k8s.io/kubernetes/pkg/kubelet/apis/kubeletconfig (from $GOROOT)
	/Users/dims/go/src/k8s.io/kubernetes/pkg/kubelet/apis/kubeletconfig (from $GOPATH)
FAIL	k8s.io/kubernetes/test/e2e_node [setup failed]

/lgtm cancel

Member

dims commented Aug 31, 2018

@balajismaniam if you rebase this to master you can see why node-e2e is failing. please fix.

[dims@dims-mac 09:27] ~/go/src/k8s.io/kubernetes ⟩ go test -v ./test/e2e_node/
# k8s.io/kubernetes/test/e2e_node
test/e2e_node/node_perf_test.go:25:2: cannot find package "k8s.io/kubernetes/pkg/kubelet/apis/kubeletconfig" in any of:
	/Users/dims/go/src/k8s.io/kubernetes/vendor/k8s.io/kubernetes/pkg/kubelet/apis/kubeletconfig (vendor tree)
	/usr/local/Cellar/go/1.10.2/libexec/src/k8s.io/kubernetes/pkg/kubelet/apis/kubeletconfig (from $GOROOT)
	/Users/dims/go/src/k8s.io/kubernetes/pkg/kubelet/apis/kubeletconfig (from $GOPATH)
FAIL	k8s.io/kubernetes/test/e2e_node [setup failed]

/lgtm cancel

@balajismaniam

This comment has been minimized.

Show comment
Hide comment
@balajismaniam

balajismaniam Sep 5, 2018

Member

/retest

Member

balajismaniam commented Sep 5, 2018

/retest

@balajismaniam

This comment has been minimized.

Show comment
Hide comment
@balajismaniam

balajismaniam Sep 5, 2018

Member

@dims I've updated the PR. It is passing all PR gates now. I've also tested it in GCP using n1-standard-16, Ubuntu 16.04 and docker 17.03.2.

CC @ConnorDoyle

Member

balajismaniam commented Sep 5, 2018

@dims I've updated the PR. It is passing all PR gates now. I've also tested it in GCP using n1-standard-16, Ubuntu 16.04 and docker 17.03.2.

CC @ConnorDoyle

@balajismaniam

This comment has been minimized.

Show comment
Hide comment
@balajismaniam

balajismaniam Sep 5, 2018

Member

/hold cancel

Member

balajismaniam commented Sep 5, 2018

/hold cancel

@ConnorDoyle

This comment has been minimized.

Show comment
Hide comment
@ConnorDoyle

ConnorDoyle Sep 5, 2018

Member

/lgtm

Member

ConnorDoyle commented Sep 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 5, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 5, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: balajismaniam, ConnorDoyle, RenaudWasTaken

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Sep 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: balajismaniam, ConnorDoyle, RenaudWasTaken

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Sep 8, 2018

Member

/priority critical-urgent

Member

dims commented Sep 8, 2018

/priority critical-urgent

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Sep 8, 2018

Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

Contributor

k8s-merge-robot commented Sep 8, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Sep 8, 2018

Contributor

Automatic merge from submit-queue (batch tested with PRs 65250, 68241). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

Contributor

k8s-merge-robot commented Sep 8, 2018

Automatic merge from submit-queue (batch tested with PRs 65250, 68241). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

@k8s-merge-robot k8s-merge-robot merged commit c9de610 into kubernetes:master Sep 8, 2018

16 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-kubemark-e2e-gce-big
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation balajismaniam authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 8, 2018

Contributor

@balajismaniam: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-kubemark-e2e-gce-big 7c4411e link /test pull-kubernetes-kubemark-e2e-gce-big

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

k8s-ci-robot commented Sep 8, 2018

@balajismaniam: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-kubemark-e2e-gce-big 7c4411e link /test pull-kubernetes-kubemark-e2e-gce-big

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment