Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cadvisor godeps (master) to v0.30.2 #65334

Merged
merged 1 commit into from Jun 22, 2018

Conversation

@dashpole
Copy link
Contributor

dashpole commented Jun 21, 2018

What this PR does / why we need it:
Update cadvisor godeps to v0.30.2. This is needed to fix a number of bugs.
Normally, we wait to do this until the quarterly cAdvisor release, but we want to get some soak time on these bug fixes so that we know it is safe to cherry-pick them to previous releases:
#65331
#65328
#65327

Release note:

Fix concurrent map access panic
Don't watch .mount cgroups to reduce number of inotify watches
Fix NVML initialization race condition
Fix brtfs disk metrics when using a subdirectory of a subvolume

/kind bug
/sig node
/priority important-soon
/assign @dchen1107

cc @yujuhong @mindprince

@mindprince
Copy link
Member

mindprince left a comment

/lgtm

@dchen1107

This comment has been minimized.

Copy link
Member

dchen1107 commented Jun 21, 2018

/retest

@dashpole dashpole force-pushed the dashpole:update_cadvisor_head branch from b9c5f14 to e13362c Jun 21, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 21, 2018

@dashpole dashpole changed the title Update cadvisor godeps to master Update cadvisor godeps to v0.30.2 Jun 21, 2018

@dashpole

This comment has been minimized.

Copy link
Contributor Author

dashpole commented Jun 21, 2018

This now bumps cadvisor godeps to v0.30.2. This is because of google/cadvisor#1967, which updated the docker godep in cAdvisor, which @jessfraz hasn't updated in k/k yet.

@dashpole

This comment has been minimized.

Copy link
Contributor Author

dashpole commented Jun 21, 2018

This should still give us a good signal for cherrypicks.

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 21, 2018

@mindprince
Copy link
Member

mindprince left a comment

/lgtm

@dashpole dashpole changed the title Update cadvisor godeps to v0.30.2 Update cadvisor godeps (master) to v0.30.2 Jun 21, 2018

@dashpole

This comment has been minimized.

Copy link
Contributor Author

dashpole commented Jun 21, 2018

/retest

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Jun 21, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jun 21, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, mindprince, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Jun 21, 2018

This now bumps cadvisor godeps to v0.30.2. This is because of google/cadvisor#1967, which updated the docker godep in cAdvisor, which @jessfraz hasn't updated in k/k yet.

Is the release note still accurate?

Nit: update the release note to make it clear that this PR bumps the cadvisor version.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jun 22, 2018

Automatic merge from submit-queue (batch tested with PRs 65290, 65326, 65289, 65334, 64860). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 98225e7 into kubernetes:master Jun 22, 2018

17 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation dashpole authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

mindprince added a commit to mindprince/kubernetes that referenced this pull request Jun 22, 2018

Remove unneeded sleep from test.
The race condition that required this sleep was fixed in google/cadvisor#1969.
That was vendored in kubernetes#65334.

k8s-github-robot pushed a commit that referenced this pull request Jun 22, 2018

Kubernetes Submit Queue
Merge pull request #65376 from mindprince/to-done
Automatic merge from submit-queue (batch tested with PRs 65377, 63837, 65370, 65294, 65376). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove unneeded sleep from test.

The race condition that required this sleep was fixed in google/cadvisor#1969.
That was vendored in #65334.

```release-note
NONE
```

/assign @jiayingz @vishh

freehan added a commit to freehan/kubernetes that referenced this pull request Jun 23, 2018

Remove unneeded sleep from test.
The race condition that required this sleep was fixed in google/cadvisor#1969.
That was vendored in kubernetes#65334.

@dashpole dashpole deleted the dashpole:update_cadvisor_head branch Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.